diff --git a/Dockerfile b/Dockerfile index 2a8f9181e6..c428761033 100644 --- a/Dockerfile +++ b/Dockerfile @@ -190,7 +190,7 @@ RUN ln -s /usr/local/completion/bash/docker /etc/bash_completion.d/docker ENTRYPOINT ["hack/dind"] # Options for hack/validate/gometalinter -ENV GOMETALINTER_OPTS="--deadline 2m" +ENV GOMETALINTER_OPTS="--deadline=2m" # Upload docker source COPY . /go/src/github.com/docker/docker diff --git a/Dockerfile.aarch64 b/Dockerfile.aarch64 index fde0c706fb..4302a5e1a4 100644 --- a/Dockerfile.aarch64 +++ b/Dockerfile.aarch64 @@ -159,7 +159,7 @@ ENV PATH=/usr/local/cli:$PATH ENTRYPOINT ["hack/dind"] # Options for hack/validate/gometalinter -ENV GOMETALINTER_OPTS="--deadline 4m -j2" +ENV GOMETALINTER_OPTS="--deadline=4m -j2" # Upload docker source COPY . /go/src/github.com/docker/docker diff --git a/Dockerfile.armhf b/Dockerfile.armhf index b5a4d938a4..f489a6cde2 100644 --- a/Dockerfile.armhf +++ b/Dockerfile.armhf @@ -147,7 +147,7 @@ ENV PATH=/usr/local/cli:$PATH ENTRYPOINT ["hack/dind"] # Options for hack/validate/gometalinter -ENV GOMETALINTER_OPTS="--deadline 10m -j2" +ENV GOMETALINTER_OPTS="--deadline=10m -j2" # Upload docker source COPY . /go/src/github.com/docker/docker diff --git a/hack/validate/gometalinter b/hack/validate/gometalinter index ae411e864a..8f42597fce 100755 --- a/hack/validate/gometalinter +++ b/hack/validate/gometalinter @@ -6,6 +6,8 @@ SCRIPTDIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )" # CI platforms differ, so per-platform GOMETALINTER_OPTS can be set # from a platform-specific Dockerfile, otherwise let's just set # (somewhat pessimistic) default of 10 minutes. +: ${GOMETALINTER_OPTS=--deadline=10m} + gometalinter \ - ${GOMETALINTER_OPTS:--deadine 10m} \ + ${GOMETALINTER_OPTS} \ --config $SCRIPTDIR/gometalinter.json ./...