beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

goroutine fairness is not guaranteed causing the hang with GCCGO

Browse source 
Signed-off-by: Srini Brahmaroutu <srbrahma@us.ibm.com>
This commit is contained in:
Srini Brahmaroutu 2015-09-25 00:13:38 +00:00
parent 84b53c8d87
commit 7c52fcce85
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
pkg/ioutils/readers.go
View file

@ -84,6 +84,9 @@ func NewBufReaderWithDrainbufAndBuffer(r io.Reader, drainBuffer []byte, buffer i
func (r *bufReader) drain() {
for {
//Call to scheduler is made to yield from this goroutine.
//This avoids goroutine looping here when n=0,err=nil, fixes code hangs when run with GCC Go.
callSchedulerIfNecessary()
n, err := r.reader.Read(r.drainBuf)
r.Lock()
if err != nil {
@ -98,7 +101,6 @@ func (r *bufReader) drain() {
}
r.wait.Signal()
r.Unlock()
callSchedulerIfNecessary()
if err != nil {
break
}