beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

golangci-lint: suppress remaining deprecation errors for now (staticcheck)

Browse source 
```
distribution/registry.go:84:3: SA1019: base.Dial is deprecated: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority.  (staticcheck)
registry/registry.go:188:3:    SA1019: base.Dial is deprecated: Use DialContext instead, which allows the transport to cancel dials as soon as they are no longer needed. If both are set, DialContext takes priority.  (staticcheck)

client/hijack.go:85:16:                               SA1019: httputil.NewClientConn is deprecated: Use the Client or Transport in package net/http instead.  (staticcheck)
integration-cli/docker_api_attach_test.go:245:12:     SA1019: httputil.NewClientConn is deprecated: Use the Client or Transport in package net/http instead.  (staticcheck)
integration/plugin/authz/authz_plugin_test.go:180:7:  SA1019: httputil.NewClientConn is deprecated: Use the Client or Transport in package net/http instead.  (staticcheck)
integration/plugin/authz/authz_plugin_test.go:479:12: SA1019: httputil.NewClientConn is deprecated: Use the Client or Transport in package net/http instead.  (staticcheck)

integration-cli/docker_api_attach_test.go:239:134:    SA1019: httputil.ClientConn is deprecated: Use Client or Transport in package net/http instead.  (staticcheck)

daemon/daemon.go:885:3:                               SA1019: grpc.WithDialer is deprecated: use WithContextDialer instead.  Will be supported throughout 1.x.  (staticcheck)

pkg/authorization/response.go:18:2:                   SA1019: http.CloseNotifier is deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead.  (staticcheck)
pkg/authorization/response.go:160:30:                 SA1019: http.CloseNotifier is deprecated: the CloseNotifier interface predates Go's context package. New code should use Request.Context instead.  (staticcheck)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2019-09-11 19:41:03 +02:00
parent df7d719e4c
commit 6f0dfe44eb
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 20 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
hack/validate/golangci-lint.yml
View file

@ -46,6 +46,14 @@ issues:
- text: "G202: SQL string concatenation"
linters:
- gosec
# FIXME temporarily suppress these. See #39925
- text: "SA1019: base.Dial is deprecated"
linters:
- staticcheck
# FIXME temporarily suppress these. See #39928
- text: "SA1019: grpc.WithDialer is deprecated"
linters:
- staticcheck
# FIXME temporarily suppress these. See #39924
- text: "SA1019: h.Xattrs is deprecated: Use PAXRecords instead"
linters:
@ -54,3 +62,15 @@ issues:
- text: "SA1019: hdr.Xattrs is deprecated: Use PAXRecords instead"
linters:
- staticcheck
# FIXME temporarily suppress these. See #39929
- text: "SA1019: http.CloseNotifier is deprecated"
linters:
- staticcheck
# FIXME temporarily suppress these. See #39926
- text: "SA1019: httputil.NewClientConn is deprecated"
linters:
- staticcheck
# FIXME temporarily suppress these. See #39927
- text: "SA1019: httputil.ClientConn is deprecated"
linters:
- staticcheck