beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

Use pool for pubsub Publish's waitgroups

Browse source 
benchmark             old ns/op      new ns/op      delta
BenchmarkPubSub-8     1036494796     1032443513     -0.39%

benchmark             old allocs     new allocs     delta
BenchmarkPubSub-8     2467           1441           -41.59%

benchmark             old bytes     new bytes     delta
BenchmarkPubSub-8     212216        187792        -11.51%

Signed-off-by: Brian Goff <cpuguy83@gmail.com>
This commit is contained in:
Brian Goff 2016-02-17 14:28:59 -05:00
parent eae59c4226
commit 58d98f8288
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
pkg/pubsub/publisher.go
View file

@ -5,6 +5,8 @@ import (
"time" "time"
) )
var wgPool = sync.Pool{New: func() interface{} { return new(sync.WaitGroup) }}
// NewPublisher creates a new pub/sub publisher to broadcast messages. // NewPublisher creates a new pub/sub publisher to broadcast messages.
// The duration is used as the send timeout as to not block the publisher publishing // The duration is used as the send timeout as to not block the publisher publishing
// messages to other clients if one client is slow or unresponsive. // messages to other clients if one client is slow or unresponsive.
@ -69,12 +71,13 @@ func (p *Publisher) Publish(v interface{}) {
return return
} }
wg := new(sync.WaitGroup) wg := wgPool.Get().(*sync.WaitGroup)
for sub, topic := range p.subscribers { for sub, topic := range p.subscribers {
wg.Add(1) wg.Add(1)
go p.sendTopic(sub, topic, v, wg) go p.sendTopic(sub, topic, v, wg)
} }
wg.Wait() wg.Wait()
wgPool.Put(wg)
p.m.RUnlock() p.m.RUnlock()
} }