Fix race in setting plugin refcounts.
Signed-off-by: Anusha Ragunathan <anusha@docker.com>
This commit is contained in:
parent
b00f1c8623
commit
4c088d1e2e
2 changed files with 4 additions and 4 deletions
|
@ -174,7 +174,7 @@ func (ps *Store) Get(name, capability string, mode int) (plugingetter.CompatPlug
|
|||
}
|
||||
p, err = ps.GetByName(fullName)
|
||||
if err == nil {
|
||||
p.SetRefCount(mode + p.GetRefCount())
|
||||
p.AddRefCount(mode)
|
||||
if p.IsEnabled() {
|
||||
return p.FilterByCap(capability)
|
||||
}
|
||||
|
|
|
@ -278,12 +278,12 @@ func (p *Plugin) GetRefCount() int {
|
|||
return p.refCount
|
||||
}
|
||||
|
||||
// SetRefCount sets the reference count.
|
||||
func (p *Plugin) SetRefCount(count int) {
|
||||
// AddRefCount adds to reference count.
|
||||
func (p *Plugin) AddRefCount(count int) {
|
||||
p.mu.Lock()
|
||||
defer p.mu.Unlock()
|
||||
|
||||
p.refCount = count
|
||||
p.refCount += count
|
||||
}
|
||||
|
||||
// InitSpec creates an OCI spec from the plugin's config.
|
||||
|
|
Loading…
Reference in a new issue