From 402e0b58ca1b1e537b92348e68f5e6bd08709ddb Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Sun, 9 Oct 2022 17:26:31 +0200 Subject: [PATCH] testutil: use filepath.WalkDir instead of filepath.Walk WalkDir is more performant as it doesn't perform an os.Lstat on every visited file or directory. Signed-off-by: Sebastiaan van Stijn --- testutil/daemon/daemon_linux.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/testutil/daemon/daemon_linux.go b/testutil/daemon/daemon_linux.go index 720c52a436..0cff545fd1 100644 --- a/testutil/daemon/daemon_linux.go +++ b/testutil/daemon/daemon_linux.go @@ -18,8 +18,7 @@ func cleanupNetworkNamespace(t testing.TB, d *Daemon) { // daemon instance and has no chance of getting // cleaned up when a new daemon is instantiated with a // new exec root. - netnsPath := filepath.Join(d.execRoot, "netns") - filepath.Walk(netnsPath, func(path string, info os.FileInfo, err error) error { + filepath.WalkDir(filepath.Join(d.execRoot, "netns"), func(path string, _ os.DirEntry, _ error) error { if err := unix.Unmount(path, unix.MNT_DETACH); err != nil && err != unix.EINVAL && err != unix.ENOENT { t.Logf("[%s] unmount of %s failed: %v", d.id, path, err) }