From 3c2b06099d37e6ae14405a02c4aceb3e9f81548e Mon Sep 17 00:00:00 2001 From: Djordje Lukic Date: Thu, 2 Nov 2023 16:09:35 +0100 Subject: [PATCH] Skip TestPullManifestList when using containerd This test is very weird, the Size in the manifests that it creates is wrong, graph drivers only print a warning in that case but containerd fails because it verifies more things. The media types are also wrong in the containerd case, the manifest list forces the media type to be "schema2.MediaTypeManifest" but in the containerd case the media type is an OCI one. Signed-off-by: Djordje Lukic --- integration-cli/docker_cli_pull_local_test.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/integration-cli/docker_cli_pull_local_test.go b/integration-cli/docker_cli_pull_local_test.go index 1b2169b610..fbf72d1ebb 100644 --- a/integration-cli/docker_cli_pull_local_test.go +++ b/integration-cli/docker_cli_pull_local_test.go @@ -18,6 +18,7 @@ import ( "github.com/opencontainers/go-digest" "gotest.tools/v3/assert" "gotest.tools/v3/icmd" + "gotest.tools/v3/skip" ) // testPullImageWithAliases pulls a specific image tag and verifies that any aliases (i.e., other @@ -283,6 +284,7 @@ func (s *DockerSchema1RegistrySuite) TestPullNoLayers(c *testing.T) { } func (s *DockerRegistrySuite) TestPullManifestList(c *testing.T) { + skip.If(c, testEnv.UsingSnapshotter(), "containerd knows how to pull manifest lists") pushDigest, err := setupImage(c) assert.NilError(c, err, "error setting up image")