testutil/daemon: remove redundant d.cmd.Wait()

`daemon.StartWithLogFile()` already creates a goroutine that
calls `d.cmd.Waits()` and sends its return to the channel, `d.Wait`.

This code called `d.cmd.Wait()` one more time, and returns the
error, which may produce an error _because_ it's called a second
time, and potentially cause an incorrect test-result.

(thanks to Kir Kolyshkin for spotting this)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2019-10-09 22:20:08 +02:00
parent c56bfdf10a
commit 293c1a27a2
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C

View file

@ -524,7 +524,7 @@ out2:
return err
}
return d.cmd.Wait()
return nil
}
// Restart will restart the daemon by first stopping it and the starting it.