From 073f8df0fef934a72f5d74adb6e9f8d2fe09a06f Mon Sep 17 00:00:00 2001 From: Sebastiaan van Stijn Date: Fri, 27 Aug 2021 00:00:48 +0200 Subject: [PATCH] libnetwork/types: remove TransportPort.FromString() as it's unused Signed-off-by: Sebastiaan van Stijn --- libnetwork/types/types.go | 14 -------------- libnetwork/types/types_test.go | 17 ----------------- 2 files changed, 31 deletions(-) diff --git a/libnetwork/types/types.go b/libnetwork/types/types.go index 7fe7dc29a8..e4ade05902 100644 --- a/libnetwork/types/types.go +++ b/libnetwork/types/types.go @@ -5,7 +5,6 @@ import ( "bytes" "fmt" "net" - "strconv" "strings" "github.com/ishidawataru/sctp" @@ -69,19 +68,6 @@ func (t *TransportPort) String() string { return fmt.Sprintf("%s/%d", t.Proto.String(), t.Port) } -// FromString reads the TransportPort structure from string -func (t *TransportPort) FromString(s string) error { - ps := strings.Split(s, "/") - if len(ps) == 2 { - t.Proto = ParseProtocol(ps[0]) - if p, err := strconv.ParseUint(ps[1], 10, 16); err == nil { - t.Port = uint16(p) - return nil - } - } - return BadRequestErrorf("invalid format for transport port: %s", s) -} - // PortBinding represents a port binding between the container and the host type PortBinding struct { Proto Protocol diff --git a/libnetwork/types/types_test.go b/libnetwork/types/types_test.go index c529ab7f86..b32a0007dd 100644 --- a/libnetwork/types/types_test.go +++ b/libnetwork/types/types_test.go @@ -5,23 +5,6 @@ import ( "testing" ) -func TestTransportPortConv(t *testing.T) { - sform := "tcp/23" - tp := &TransportPort{Proto: TCP, Port: uint16(23)} - - if sform != tp.String() { - t.Fatalf("String() method failed") - } - - rc := new(TransportPort) - if err := rc.FromString(sform); err != nil { - t.Fatal(err) - } - if !tp.Equal(rc) { - t.Fatalf("FromString() method failed") - } -} - func TestErrorConstructors(t *testing.T) { var err error