beenull/moby
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity

integration-cli: fix golint issues

Browse source 
```
docker/integration-cli/checker/checker.go
Line 12: warning: exported type Compare should have comment or be unexported (golint)
Line 14: warning: exported function False should have comment or be unexported (golint)
Line 20: warning: exported function True should have comment or be unexported (golint)
Line 26: warning: exported function Equals should have comment or be unexported (golint)
Line 32: warning: exported function Contains should have comment or be unexported (golint)
Line 38: warning: exported function Not should have comment or be unexported (golint)
Line 52: warning: exported function DeepEquals should have comment or be unexported (golint)
Line 58: warning: exported function HasLen should have comment or be unexported (golint)
Line 64: warning: exported function IsNil should have comment or be unexported (golint)
Line 70: warning: exported function GreaterThan should have comment or be unexported (golint)
Line 76: warning: exported function NotNil should have comment or be unexported (golint)
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
(cherry picked from commit 6397dd4d31)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
This commit is contained in:
Sebastiaan van Stijn 2019-09-19 09:50:42 +02:00
parent da8cd68e4f
commit 06f11abf43
No known key found for this signature in database
GPG key ID: 76698F39D527CE8C
1 changed files with 10 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
integration-cli/checker/checker.go
View file

@ -9,32 +9,38 @@ import (
"gotest.tools/assert/cmp" "gotest.tools/assert/cmp"
) )
// Compare defines the interface to compare values
type Compare func(x interface{}) assert.BoolOrComparison type Compare func(x interface{}) assert.BoolOrComparison
// False checks if the value is false
func False() Compare { func False() Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return !x.(bool) return !x.(bool)
} }
} }
// True checks if the value is true
func True() Compare { func True() Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return x return x
} }
} }
// Equals checks if the value is equal to the given value
func Equals(y interface{}) Compare { func Equals(y interface{}) Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return cmp.Equal(x, y) return cmp.Equal(x, y)
} }
} }
// Contains checks if the value contains the given value
func Contains(y interface{}) Compare { func Contains(y interface{}) Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return cmp.Contains(x, y) return cmp.Contains(x, y)
} }
} }
// Not checks if two values are not
func Not(c Compare) Compare { func Not(c Compare) Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
r := c(x) r := c(x)
@ -49,30 +55,30 @@ func Not(c Compare) Compare {
} }
} }
// DeepEquals checks if two values are equal
func DeepEquals(y interface{}) Compare { func DeepEquals(y interface{}) Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return cmp.DeepEqual(x, y) return cmp.DeepEqual(x, y)
} }
} }
// DeepEquals compares if two values are deepequal
func HasLen(y int) Compare { func HasLen(y int) Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return cmp.Len(x, y) return cmp.Len(x, y)
} }
} }
// DeepEquals checks if the given value is nil
func IsNil() Compare { func IsNil() Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return cmp.Nil(x) return cmp.Nil(x)
} }
} }
// GreaterThan checks if the value is greater than the given value
func GreaterThan(y int) Compare { func GreaterThan(y int) Compare {
return func(x interface{}) assert.BoolOrComparison { return func(x interface{}) assert.BoolOrComparison {
return x.(int) > y return x.(int) > y
} }
} }
func NotNil() Compare {
return Not(IsNil())
}