2015-07-21 22:26:52 +00:00
|
|
|
// Package logger defines interfaces that logger drivers implement to
|
|
|
|
// log messages.
|
|
|
|
//
|
|
|
|
// The other half of a logger driver is the implementation of the
|
|
|
|
// factory, which holds the contextual instance information that
|
|
|
|
// allows multiple loggers of the same type to perform different
|
|
|
|
// actions, such as logging to different locations.
|
2015-02-03 23:41:26 +00:00
|
|
|
package logger
|
|
|
|
|
2015-04-09 04:23:30 +00:00
|
|
|
import (
|
2016-06-27 21:14:17 +00:00
|
|
|
"sync"
|
2015-04-09 04:23:30 +00:00
|
|
|
"time"
|
2015-07-03 13:50:06 +00:00
|
|
|
|
2017-03-20 17:07:04 +00:00
|
|
|
"github.com/docker/docker/api/types/backend"
|
2015-04-09 04:23:30 +00:00
|
|
|
)
|
|
|
|
|
2017-07-19 14:20:13 +00:00
|
|
|
// ErrReadLogsNotSupported is returned when the underlying log driver does not support reading
|
|
|
|
type ErrReadLogsNotSupported struct{}
|
|
|
|
|
|
|
|
func (ErrReadLogsNotSupported) Error() string {
|
|
|
|
return "configured logging driver does not support reading"
|
|
|
|
}
|
|
|
|
|
|
|
|
// NotImplemented makes this error implement the `NotImplemented` interface from api/errdefs
|
|
|
|
func (ErrReadLogsNotSupported) NotImplemented() {}
|
2015-07-03 13:50:06 +00:00
|
|
|
|
|
|
|
const (
|
|
|
|
logWatcherBufferSize = 4096
|
|
|
|
)
|
2015-02-03 23:41:26 +00:00
|
|
|
|
2016-12-12 14:54:20 +00:00
|
|
|
var messagePool = &sync.Pool{New: func() interface{} { return &Message{Line: make([]byte, 0, 256)} }}
|
|
|
|
|
|
|
|
// NewMessage returns a new message from the message sync.Pool
|
|
|
|
func NewMessage() *Message {
|
|
|
|
return messagePool.Get().(*Message)
|
|
|
|
}
|
|
|
|
|
|
|
|
// PutMessage puts the specified message back n the message pool.
|
|
|
|
// The message fields are reset before putting into the pool.
|
|
|
|
func PutMessage(msg *Message) {
|
|
|
|
msg.reset()
|
|
|
|
messagePool.Put(msg)
|
|
|
|
}
|
|
|
|
|
Improve logging of long log lines
This change updates how we handle long lines of output from the
container. The previous logic used a bufio reader to read entire lines
of output from the container through an intermediate BytesPipe, and that
allowed the container to cause dockerd to consume an unconstrained
amount of memory as it attempted to collect a whole line of output, by
outputting data without newlines.
To avoid that, we replace the bufio reader with our own buffering scheme
that handles log lines up to 16k in length, breaking up anything longer
than that into multiple chunks. If we can dispense with noting this
detail properly at the end of output, we can switch from using
ReadBytes() to using ReadLine() instead. We add a field ("Partial") to
the log message structure to flag when we pass data to the log driver
that did not end with a newline.
The Line member of Message structures that we pass to log drivers is now
a slice into data which can be overwritten between calls to the log
driver's Log() method, so drivers which batch up Messages before
processing them need to take additional care: we add a function
(logger.CopyMessage()) that can be used to create a deep copy of a
Message structure, and modify the awslogs driver to use it.
We update the jsonfile log driver to append a "\n" to the data that it
logs to disk only when the Partial flag is false (it previously did so
unconditionally), to make its "logs" output correctly reproduce the data
as we received it.
Likewise, we modify the journald log driver to add a data field with
value CONTAINER_PARTIAL_MESSAGE=true to entries when the Partial flag is
true, and update its "logs" reader to refrain from appending a "\n" to
the data that it retrieves if it does not see this field/value pair (it
also previously did this unconditionally).
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com> (github: nalind)
2016-05-24 18:12:47 +00:00
|
|
|
// Message is datastructure that represents piece of output produced by some
|
|
|
|
// container. The Line member is a slice of an array whose contents can be
|
|
|
|
// changed after a log driver's Log() method returns.
|
2017-03-20 17:07:04 +00:00
|
|
|
//
|
|
|
|
// Message is subtyped from backend.LogMessage because there is a lot of
|
|
|
|
// internal complexity around the Message type that should not be exposed
|
|
|
|
// to any package not explicitly importing the logger type.
|
|
|
|
//
|
2016-12-12 14:54:20 +00:00
|
|
|
// Any changes made to this struct must also be updated in the `reset` function
|
2017-03-20 17:07:04 +00:00
|
|
|
type Message backend.LogMessage
|
Improve logging of long log lines
This change updates how we handle long lines of output from the
container. The previous logic used a bufio reader to read entire lines
of output from the container through an intermediate BytesPipe, and that
allowed the container to cause dockerd to consume an unconstrained
amount of memory as it attempted to collect a whole line of output, by
outputting data without newlines.
To avoid that, we replace the bufio reader with our own buffering scheme
that handles log lines up to 16k in length, breaking up anything longer
than that into multiple chunks. If we can dispense with noting this
detail properly at the end of output, we can switch from using
ReadBytes() to using ReadLine() instead. We add a field ("Partial") to
the log message structure to flag when we pass data to the log driver
that did not end with a newline.
The Line member of Message structures that we pass to log drivers is now
a slice into data which can be overwritten between calls to the log
driver's Log() method, so drivers which batch up Messages before
processing them need to take additional care: we add a function
(logger.CopyMessage()) that can be used to create a deep copy of a
Message structure, and modify the awslogs driver to use it.
We update the jsonfile log driver to append a "\n" to the data that it
logs to disk only when the Partial flag is false (it previously did so
unconditionally), to make its "logs" output correctly reproduce the data
as we received it.
Likewise, we modify the journald log driver to add a data field with
value CONTAINER_PARTIAL_MESSAGE=true to entries when the Partial flag is
true, and update its "logs" reader to refrain from appending a "\n" to
the data that it retrieves if it does not see this field/value pair (it
also previously did this unconditionally).
Signed-off-by: Nalin Dahyabhai <nalin@redhat.com> (github: nalind)
2016-05-24 18:12:47 +00:00
|
|
|
|
2016-12-12 14:54:20 +00:00
|
|
|
// reset sets the message back to default values
|
|
|
|
// This is used when putting a message back into the message pool.
|
|
|
|
// Any changes to the `Message` struct should be reflected here.
|
|
|
|
func (m *Message) reset() {
|
|
|
|
m.Line = m.Line[:0]
|
|
|
|
m.Source = ""
|
|
|
|
m.Attrs = nil
|
|
|
|
m.Partial = false
|
|
|
|
|
2017-03-20 17:07:04 +00:00
|
|
|
m.Err = nil
|
2016-04-08 16:15:08 +00:00
|
|
|
}
|
|
|
|
|
2017-03-20 17:07:04 +00:00
|
|
|
// AsLogMessage returns a pointer to the message as a pointer to
|
|
|
|
// backend.LogMessage, which is an identical type with a different purpose
|
|
|
|
func (m *Message) AsLogMessage() *backend.LogMessage {
|
|
|
|
return (*backend.LogMessage)(m)
|
2015-02-03 23:41:26 +00:00
|
|
|
}
|
|
|
|
|
2015-07-21 22:26:52 +00:00
|
|
|
// Logger is the interface for docker logging drivers.
|
2015-02-03 23:41:26 +00:00
|
|
|
type Logger interface {
|
|
|
|
Log(*Message) error
|
|
|
|
Name() string
|
|
|
|
Close() error
|
2015-07-01 00:40:13 +00:00
|
|
|
}
|
|
|
|
|
2015-07-21 22:26:52 +00:00
|
|
|
// ReadConfig is the configuration passed into ReadLogs.
|
2015-07-03 13:50:06 +00:00
|
|
|
type ReadConfig struct {
|
|
|
|
Since time.Time
|
|
|
|
Tail int
|
|
|
|
Follow bool
|
|
|
|
}
|
|
|
|
|
2015-07-21 22:26:52 +00:00
|
|
|
// LogReader is the interface for reading log messages for loggers that support reading.
|
2015-07-03 13:50:06 +00:00
|
|
|
type LogReader interface {
|
|
|
|
// Read logs from underlying logging backend
|
|
|
|
ReadLogs(ReadConfig) *LogWatcher
|
|
|
|
}
|
|
|
|
|
2015-07-21 22:26:52 +00:00
|
|
|
// LogWatcher is used when consuming logs read from the LogReader interface.
|
2015-07-03 13:50:06 +00:00
|
|
|
type LogWatcher struct {
|
2015-07-21 22:26:52 +00:00
|
|
|
// For sending log messages to a reader.
|
2015-07-03 13:50:06 +00:00
|
|
|
Msg chan *Message
|
2015-07-21 22:26:52 +00:00
|
|
|
// For sending error messages that occur while while reading logs.
|
2015-07-03 13:50:06 +00:00
|
|
|
Err chan error
|
2016-06-27 21:14:17 +00:00
|
|
|
closeOnce sync.Once
|
2015-07-03 13:50:06 +00:00
|
|
|
closeNotifier chan struct{}
|
|
|
|
}
|
|
|
|
|
|
|
|
// NewLogWatcher returns a new LogWatcher.
|
|
|
|
func NewLogWatcher() *LogWatcher {
|
|
|
|
return &LogWatcher{
|
|
|
|
Msg: make(chan *Message, logWatcherBufferSize),
|
|
|
|
Err: make(chan error, 1),
|
|
|
|
closeNotifier: make(chan struct{}),
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
2015-07-21 22:26:52 +00:00
|
|
|
// Close notifies the underlying log reader to stop.
|
2015-07-03 13:50:06 +00:00
|
|
|
func (w *LogWatcher) Close() {
|
2015-07-31 20:49:07 +00:00
|
|
|
// only close if not already closed
|
2016-06-27 21:14:17 +00:00
|
|
|
w.closeOnce.Do(func() {
|
2015-07-31 20:49:07 +00:00
|
|
|
close(w.closeNotifier)
|
2016-06-27 21:14:17 +00:00
|
|
|
})
|
2015-07-03 13:50:06 +00:00
|
|
|
}
|
|
|
|
|
2015-07-21 22:26:52 +00:00
|
|
|
// WatchClose returns a channel receiver that receives notification
|
|
|
|
// when the watcher has been closed. This should only be called from
|
|
|
|
// one goroutine.
|
2015-07-03 13:50:06 +00:00
|
|
|
func (w *LogWatcher) WatchClose() <-chan struct{} {
|
|
|
|
return w.closeNotifier
|
2015-02-03 23:41:26 +00:00
|
|
|
}
|
2016-11-14 18:53:53 +00:00
|
|
|
|
|
|
|
// Capability defines the list of capabilties that a driver can implement
|
|
|
|
// These capabilities are not required to be a logging driver, however do
|
|
|
|
// determine how a logging driver can be used
|
|
|
|
type Capability struct {
|
|
|
|
// Determines if a log driver can read back logs
|
|
|
|
ReadLogs bool
|
|
|
|
}
|