2015-09-25 10:19:17 +00:00
|
|
|
package daemon
|
|
|
|
|
|
|
|
import (
|
2015-10-09 18:21:48 +00:00
|
|
|
"fmt"
|
|
|
|
"net"
|
2015-09-25 10:19:17 +00:00
|
|
|
"strings"
|
|
|
|
|
2016-06-14 02:52:49 +00:00
|
|
|
"github.com/Sirupsen/logrus"
|
|
|
|
clustertypes "github.com/docker/docker/daemon/cluster/provider"
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 15:53:35 +00:00
|
|
|
"github.com/docker/docker/errors"
|
2015-12-22 04:35:30 +00:00
|
|
|
"github.com/docker/docker/runconfig"
|
2016-03-28 17:41:06 +00:00
|
|
|
"github.com/docker/engine-api/types"
|
2016-01-05 00:05:26 +00:00
|
|
|
"github.com/docker/engine-api/types/network"
|
2015-09-25 10:19:17 +00:00
|
|
|
"github.com/docker/libnetwork"
|
2016-06-14 02:52:49 +00:00
|
|
|
networktypes "github.com/docker/libnetwork/types"
|
2015-09-25 10:19:17 +00:00
|
|
|
)
|
|
|
|
|
2015-10-16 22:45:54 +00:00
|
|
|
// NetworkControllerEnabled checks if the networking stack is enabled.
|
2015-12-13 16:00:39 +00:00
|
|
|
// This feature depends on OS primitives and it's disabled in systems like Windows.
|
2015-10-16 22:45:54 +00:00
|
|
|
func (daemon *Daemon) NetworkControllerEnabled() bool {
|
|
|
|
return daemon.netController != nil
|
|
|
|
}
|
|
|
|
|
2015-09-25 10:19:17 +00:00
|
|
|
// FindNetwork function finds a network for a given string that can represent network name or id
|
|
|
|
func (daemon *Daemon) FindNetwork(idName string) (libnetwork.Network, error) {
|
|
|
|
// Find by Name
|
2015-12-30 17:20:41 +00:00
|
|
|
n, err := daemon.GetNetworkByName(idName)
|
|
|
|
if err != nil && !isNoSuchNetworkError(err) {
|
2015-09-25 10:19:17 +00:00
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
if n != nil {
|
|
|
|
return n, nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// Find by id
|
2015-12-30 17:20:41 +00:00
|
|
|
return daemon.GetNetworkByID(idName)
|
2015-09-25 10:19:17 +00:00
|
|
|
}
|
|
|
|
|
2015-12-30 17:20:41 +00:00
|
|
|
func isNoSuchNetworkError(err error) bool {
|
|
|
|
_, ok := err.(libnetwork.ErrNoSuchNetwork)
|
|
|
|
return ok
|
|
|
|
}
|
2015-09-25 10:19:17 +00:00
|
|
|
|
2015-12-30 17:20:41 +00:00
|
|
|
// GetNetworkByID function returns a network whose ID begins with the given prefix.
|
|
|
|
// It fails with an error if no matching, or more than one matching, networks are found.
|
|
|
|
func (daemon *Daemon) GetNetworkByID(partialID string) (libnetwork.Network, error) {
|
|
|
|
list := daemon.GetNetworksByID(partialID)
|
2015-09-25 10:19:17 +00:00
|
|
|
|
2015-12-30 17:20:41 +00:00
|
|
|
if len(list) == 0 {
|
|
|
|
return nil, libnetwork.ErrNoSuchNetwork(partialID)
|
|
|
|
}
|
|
|
|
if len(list) > 1 {
|
|
|
|
return nil, libnetwork.ErrInvalidID(partialID)
|
|
|
|
}
|
|
|
|
return list[0], nil
|
|
|
|
}
|
2015-09-25 10:19:17 +00:00
|
|
|
|
2015-12-30 17:20:41 +00:00
|
|
|
// GetNetworkByName function returns a network for a given network name.
|
|
|
|
func (daemon *Daemon) GetNetworkByName(name string) (libnetwork.Network, error) {
|
|
|
|
c := daemon.netController
|
|
|
|
if name == "" {
|
|
|
|
name = c.Config().Daemon.DefaultNetwork
|
2015-09-25 10:19:17 +00:00
|
|
|
}
|
2015-12-30 17:20:41 +00:00
|
|
|
return c.NetworkByName(name)
|
2015-09-25 10:19:17 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// GetNetworksByID returns a list of networks whose ID partially matches zero or more networks
|
|
|
|
func (daemon *Daemon) GetNetworksByID(partialID string) []libnetwork.Network {
|
|
|
|
c := daemon.netController
|
|
|
|
list := []libnetwork.Network{}
|
|
|
|
l := func(nw libnetwork.Network) bool {
|
|
|
|
if strings.HasPrefix(nw.ID(), partialID) {
|
|
|
|
list = append(list, nw)
|
|
|
|
}
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
c.WalkNetworks(l)
|
|
|
|
|
|
|
|
return list
|
|
|
|
}
|
|
|
|
|
2016-03-28 17:41:06 +00:00
|
|
|
// getAllNetworks returns a list containing all networks
|
|
|
|
func (daemon *Daemon) getAllNetworks() []libnetwork.Network {
|
2015-11-10 08:57:06 +00:00
|
|
|
c := daemon.netController
|
|
|
|
list := []libnetwork.Network{}
|
|
|
|
l := func(nw libnetwork.Network) bool {
|
|
|
|
list = append(list, nw)
|
|
|
|
return false
|
|
|
|
}
|
|
|
|
c.WalkNetworks(l)
|
|
|
|
|
|
|
|
return list
|
|
|
|
}
|
|
|
|
|
2016-06-14 02:52:49 +00:00
|
|
|
func isIngressNetwork(name string) bool {
|
|
|
|
return name == "ingress"
|
|
|
|
}
|
|
|
|
|
|
|
|
var ingressChan = make(chan struct{}, 1)
|
|
|
|
|
|
|
|
func ingressWait() func() {
|
|
|
|
ingressChan <- struct{}{}
|
|
|
|
return func() { <-ingressChan }
|
|
|
|
}
|
|
|
|
|
|
|
|
// SetupIngress setups ingress networking.
|
|
|
|
func (daemon *Daemon) SetupIngress(create clustertypes.NetworkCreateRequest, nodeIP string) error {
|
|
|
|
ip, _, err := net.ParseCIDR(nodeIP)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
go func() {
|
|
|
|
controller := daemon.netController
|
|
|
|
controller.AgentInitWait()
|
|
|
|
|
|
|
|
if n, err := daemon.GetNetworkByName(create.Name); err == nil && n != nil && n.ID() != create.ID {
|
|
|
|
if err := controller.SandboxDestroy("ingress-sbox"); err != nil {
|
|
|
|
logrus.Errorf("Failed to delete stale ingress sandbox: %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := n.Delete(); err != nil {
|
|
|
|
logrus.Errorf("Failed to delete stale ingress network %s: %v", n.ID(), err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if _, err := daemon.createNetwork(create.NetworkCreateRequest, create.ID, true); err != nil {
|
|
|
|
// If it is any other error other than already
|
|
|
|
// exists error log error and return.
|
|
|
|
if _, ok := err.(libnetwork.NetworkNameError); !ok {
|
|
|
|
logrus.Errorf("Failed creating ingress network: %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
// Otherwise continue down the call to create or recreate sandbox.
|
|
|
|
}
|
|
|
|
|
|
|
|
n, err := daemon.GetNetworkByID(create.ID)
|
|
|
|
if err != nil {
|
|
|
|
logrus.Errorf("Failed getting ingress network by id after creating: %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
sb, err := controller.NewSandbox("ingress-sbox", libnetwork.OptionIngress())
|
|
|
|
if err != nil {
|
|
|
|
logrus.Errorf("Failed creating ingress sanbox: %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
ep, err := n.CreateEndpoint("ingress-endpoint", libnetwork.CreateOptionIpam(ip, nil, nil, nil))
|
|
|
|
if err != nil {
|
|
|
|
logrus.Errorf("Failed creating ingress endpoint: %v", err)
|
|
|
|
return
|
|
|
|
}
|
|
|
|
|
|
|
|
if err := ep.Join(sb, nil); err != nil {
|
|
|
|
logrus.Errorf("Failed joining ingress sandbox to ingress endpoint: %v", err)
|
|
|
|
}
|
|
|
|
}()
|
|
|
|
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
|
|
|
// SetNetworkBootstrapKeys sets the bootstrap keys.
|
|
|
|
func (daemon *Daemon) SetNetworkBootstrapKeys(keys []*networktypes.EncryptionKey) error {
|
|
|
|
return daemon.netController.SetKeys(keys)
|
|
|
|
}
|
|
|
|
|
|
|
|
// CreateManagedNetwork creates an agent network.
|
|
|
|
func (daemon *Daemon) CreateManagedNetwork(create clustertypes.NetworkCreateRequest) error {
|
|
|
|
_, err := daemon.createNetwork(create.NetworkCreateRequest, create.ID, true)
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2015-09-25 10:19:17 +00:00
|
|
|
// CreateNetwork creates a network with the given name, driver and other optional parameters
|
2016-04-13 08:33:46 +00:00
|
|
|
func (daemon *Daemon) CreateNetwork(create types.NetworkCreateRequest) (*types.NetworkCreateResponse, error) {
|
2016-06-14 02:52:49 +00:00
|
|
|
resp, err := daemon.createNetwork(create, "", false)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
return resp, err
|
|
|
|
}
|
|
|
|
|
|
|
|
func (daemon *Daemon) createNetwork(create types.NetworkCreateRequest, id string, agent bool) (*types.NetworkCreateResponse, error) {
|
|
|
|
// If there is a pending ingress network creation wait here
|
|
|
|
// since ingress network creation can happen via node download
|
|
|
|
// from manager or task download.
|
|
|
|
if isIngressNetwork(create.Name) {
|
|
|
|
defer ingressWait()()
|
|
|
|
}
|
|
|
|
|
|
|
|
if runconfig.IsPreDefinedNetwork(create.Name) && !agent {
|
2016-03-28 17:41:06 +00:00
|
|
|
err := fmt.Errorf("%s is a pre-defined network and cannot be created", create.Name)
|
2016-05-02 08:54:09 +00:00
|
|
|
return nil, errors.NewRequestForbiddenError(err)
|
2016-03-28 17:41:06 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
var warning string
|
|
|
|
nw, err := daemon.GetNetworkByName(create.Name)
|
|
|
|
if err != nil {
|
|
|
|
if _, ok := err.(libnetwork.ErrNoSuchNetwork); !ok {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
}
|
|
|
|
if nw != nil {
|
|
|
|
if create.CheckDuplicate {
|
|
|
|
return nil, libnetwork.NetworkNameError(create.Name)
|
|
|
|
}
|
|
|
|
warning = fmt.Sprintf("Network with name %s (id : %s) already exists", nw.Name(), nw.ID())
|
|
|
|
}
|
|
|
|
|
2015-09-25 10:19:17 +00:00
|
|
|
c := daemon.netController
|
2016-03-28 17:41:06 +00:00
|
|
|
driver := create.Driver
|
2015-09-25 10:19:17 +00:00
|
|
|
if driver == "" {
|
|
|
|
driver = c.Config().Daemon.DefaultDriver
|
|
|
|
}
|
|
|
|
|
2016-03-28 17:41:06 +00:00
|
|
|
ipam := create.IPAM
|
2015-10-09 18:21:48 +00:00
|
|
|
v4Conf, v6Conf, err := getIpamConfig(ipam.Config)
|
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
2016-03-16 21:52:34 +00:00
|
|
|
nwOptions := []libnetwork.NetworkOption{
|
|
|
|
libnetwork.NetworkOptionIpam(ipam.Driver, "", v4Conf, v6Conf, ipam.Options),
|
2016-03-28 17:41:06 +00:00
|
|
|
libnetwork.NetworkOptionEnableIPv6(create.EnableIPv6),
|
|
|
|
libnetwork.NetworkOptionDriverOpts(create.Options),
|
|
|
|
libnetwork.NetworkOptionLabels(create.Labels),
|
2016-03-16 21:52:34 +00:00
|
|
|
}
|
2016-03-28 17:41:06 +00:00
|
|
|
if create.Internal {
|
2015-12-28 02:15:50 +00:00
|
|
|
nwOptions = append(nwOptions, libnetwork.NetworkOptionInternalNetwork())
|
|
|
|
}
|
2016-06-14 02:52:49 +00:00
|
|
|
if agent {
|
|
|
|
nwOptions = append(nwOptions, libnetwork.NetworkOptionDynamic())
|
|
|
|
nwOptions = append(nwOptions, libnetwork.NetworkOptionPersist(false))
|
|
|
|
}
|
|
|
|
|
|
|
|
if isIngressNetwork(create.Name) {
|
|
|
|
nwOptions = append(nwOptions, libnetwork.NetworkOptionIngress())
|
|
|
|
}
|
|
|
|
|
|
|
|
n, err := c.NewNetwork(driver, create.Name, id, nwOptions...)
|
2015-12-22 04:35:30 +00:00
|
|
|
if err != nil {
|
|
|
|
return nil, err
|
|
|
|
}
|
|
|
|
|
|
|
|
daemon.LogNetworkEvent(n, "create")
|
2016-03-28 17:41:06 +00:00
|
|
|
return &types.NetworkCreateResponse{
|
|
|
|
ID: n.ID(),
|
|
|
|
Warning: warning,
|
|
|
|
}, nil
|
2015-10-09 18:21:48 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
func getIpamConfig(data []network.IPAMConfig) ([]*libnetwork.IpamConf, []*libnetwork.IpamConf, error) {
|
|
|
|
ipamV4Cfg := []*libnetwork.IpamConf{}
|
|
|
|
ipamV6Cfg := []*libnetwork.IpamConf{}
|
|
|
|
for _, d := range data {
|
|
|
|
iCfg := libnetwork.IpamConf{}
|
|
|
|
iCfg.PreferredPool = d.Subnet
|
|
|
|
iCfg.SubPool = d.IPRange
|
|
|
|
iCfg.Gateway = d.Gateway
|
|
|
|
iCfg.AuxAddresses = d.AuxAddress
|
|
|
|
ip, _, err := net.ParseCIDR(d.Subnet)
|
|
|
|
if err != nil {
|
|
|
|
return nil, nil, fmt.Errorf("Invalid subnet %s : %v", d.Subnet, err)
|
|
|
|
}
|
|
|
|
if ip.To4() != nil {
|
|
|
|
ipamV4Cfg = append(ipamV4Cfg, &iCfg)
|
|
|
|
} else {
|
|
|
|
ipamV6Cfg = append(ipamV6Cfg, &iCfg)
|
|
|
|
}
|
|
|
|
}
|
|
|
|
return ipamV4Cfg, ipamV6Cfg, nil
|
2015-09-25 10:19:17 +00:00
|
|
|
}
|
2015-10-13 22:44:23 +00:00
|
|
|
|
2016-06-14 02:52:49 +00:00
|
|
|
// UpdateContainerServiceConfig updates a service configuration.
|
|
|
|
func (daemon *Daemon) UpdateContainerServiceConfig(containerName string, serviceConfig *clustertypes.ServiceConfig) error {
|
|
|
|
container, err := daemon.GetContainer(containerName)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
|
|
|
container.NetworkSettings.Service = serviceConfig
|
|
|
|
return nil
|
|
|
|
}
|
|
|
|
|
2015-10-13 22:44:23 +00:00
|
|
|
// ConnectContainerToNetwork connects the given container to the given
|
|
|
|
// network. If either cannot be found, an err is returned. If the
|
|
|
|
// network cannot be set up, an err is returned.
|
2016-01-08 00:18:34 +00:00
|
|
|
func (daemon *Daemon) ConnectContainerToNetwork(containerName, networkName string, endpointConfig *network.EndpointSettings) error {
|
2015-12-11 17:39:28 +00:00
|
|
|
container, err := daemon.GetContainer(containerName)
|
2015-10-13 22:44:23 +00:00
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
2016-01-08 00:18:34 +00:00
|
|
|
return daemon.ConnectToNetwork(container, networkName, endpointConfig)
|
2015-10-13 22:44:23 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
// DisconnectContainerFromNetwork disconnects the given container from
|
|
|
|
// the given network. If either cannot be found, an err is returned.
|
2016-01-13 04:56:36 +00:00
|
|
|
func (daemon *Daemon) DisconnectContainerFromNetwork(containerName string, network libnetwork.Network, force bool) error {
|
2015-12-11 17:39:28 +00:00
|
|
|
container, err := daemon.GetContainer(containerName)
|
2015-10-13 22:44:23 +00:00
|
|
|
if err != nil {
|
2016-01-13 04:56:36 +00:00
|
|
|
if force {
|
|
|
|
return daemon.ForceEndpointDelete(containerName, network)
|
|
|
|
}
|
2015-10-13 22:44:23 +00:00
|
|
|
return err
|
|
|
|
}
|
2016-01-13 04:56:36 +00:00
|
|
|
return daemon.DisconnectFromNetwork(container, network, force)
|
2015-10-13 22:44:23 +00:00
|
|
|
}
|
2015-10-23 06:08:26 +00:00
|
|
|
|
|
|
|
// GetNetworkDriverList returns the list of plugins drivers
|
|
|
|
// registered for network.
|
|
|
|
func (daemon *Daemon) GetNetworkDriverList() map[string]bool {
|
|
|
|
pluginList := make(map[string]bool)
|
|
|
|
|
2015-11-19 19:02:25 +00:00
|
|
|
if !daemon.NetworkControllerEnabled() {
|
|
|
|
return nil
|
|
|
|
}
|
2015-10-23 06:08:26 +00:00
|
|
|
c := daemon.netController
|
|
|
|
networks := c.Networks()
|
|
|
|
|
|
|
|
for _, network := range networks {
|
|
|
|
driver := network.Type()
|
|
|
|
pluginList[driver] = true
|
|
|
|
}
|
2016-06-14 02:52:49 +00:00
|
|
|
// TODO : Replace this with proper libnetwork API
|
|
|
|
pluginList["overlay"] = true
|
2015-10-23 06:08:26 +00:00
|
|
|
|
|
|
|
return pluginList
|
|
|
|
}
|
2015-12-22 04:35:30 +00:00
|
|
|
|
2016-06-14 02:52:49 +00:00
|
|
|
// DeleteManagedNetwork deletes an agent network.
|
|
|
|
func (daemon *Daemon) DeleteManagedNetwork(networkID string) error {
|
|
|
|
return daemon.deleteNetwork(networkID, true)
|
|
|
|
}
|
|
|
|
|
2015-12-22 04:35:30 +00:00
|
|
|
// DeleteNetwork destroys a network unless it's one of docker's predefined networks.
|
|
|
|
func (daemon *Daemon) DeleteNetwork(networkID string) error {
|
2016-06-14 02:52:49 +00:00
|
|
|
return daemon.deleteNetwork(networkID, false)
|
|
|
|
}
|
|
|
|
|
|
|
|
func (daemon *Daemon) deleteNetwork(networkID string, dynamic bool) error {
|
2015-12-22 04:35:30 +00:00
|
|
|
nw, err := daemon.FindNetwork(networkID)
|
|
|
|
if err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
|
2016-06-14 02:52:49 +00:00
|
|
|
if runconfig.IsPreDefinedNetwork(nw.Name()) && !dynamic {
|
Remove static errors from errors package.
Moving all strings to the errors package wasn't a good idea after all.
Our custom implementation of Go errors predates everything that's nice
and good about working with errors in Go. Take as an example what we
have to do to get an error message:
```go
func GetErrorMessage(err error) string {
switch err.(type) {
case errcode.Error:
e, _ := err.(errcode.Error)
return e.Message
case errcode.ErrorCode:
ec, _ := err.(errcode.ErrorCode)
return ec.Message()
default:
return err.Error()
}
}
```
This goes against every good practice for Go development. The language already provides a simple, intuitive and standard way to get error messages, that is calling the `Error()` method from an error. Reinventing the error interface is a mistake.
Our custom implementation also makes very hard to reason about errors, another nice thing about Go. I found several (>10) error declarations that we don't use anywhere. This is a clear sign about how little we know about the errors we return. I also found several error usages where the number of arguments was different than the parameters declared in the error, another clear example of how difficult is to reason about errors.
Moreover, our custom implementation didn't really make easier for people to return custom HTTP status code depending on the errors. Again, it's hard to reason about when to set custom codes and how. Take an example what we have to do to extract the message and status code from an error before returning a response from the API:
```go
switch err.(type) {
case errcode.ErrorCode:
daError, _ := err.(errcode.ErrorCode)
statusCode = daError.Descriptor().HTTPStatusCode
errMsg = daError.Message()
case errcode.Error:
// For reference, if you're looking for a particular error
// then you can do something like :
// import ( derr "github.com/docker/docker/errors" )
// if daError.ErrorCode() == derr.ErrorCodeNoSuchContainer { ... }
daError, _ := err.(errcode.Error)
statusCode = daError.ErrorCode().Descriptor().HTTPStatusCode
errMsg = daError.Message
default:
// This part of will be removed once we've
// converted everything over to use the errcode package
// FIXME: this is brittle and should not be necessary.
// If we need to differentiate between different possible error types,
// we should create appropriate error types with clearly defined meaning
errStr := strings.ToLower(err.Error())
for keyword, status := range map[string]int{
"not found": http.StatusNotFound,
"no such": http.StatusNotFound,
"bad parameter": http.StatusBadRequest,
"conflict": http.StatusConflict,
"impossible": http.StatusNotAcceptable,
"wrong login/password": http.StatusUnauthorized,
"hasn't been activated": http.StatusForbidden,
} {
if strings.Contains(errStr, keyword) {
statusCode = status
break
}
}
}
```
You can notice two things in that code:
1. We have to explain how errors work, because our implementation goes against how easy to use Go errors are.
2. At no moment we arrived to remove that `switch` statement that was the original reason to use our custom implementation.
This change removes all our status errors from the errors package and puts them back in their specific contexts.
IT puts the messages back with their contexts. That way, we know right away when errors used and how to generate their messages.
It uses custom interfaces to reason about errors. Errors that need to response with a custom status code MUST implementent this simple interface:
```go
type errorWithStatus interface {
HTTPErrorStatusCode() int
}
```
This interface is very straightforward to implement. It also preserves Go errors real behavior, getting the message is as simple as using the `Error()` method.
I included helper functions to generate errors that use custom status code in `errors/errors.go`.
By doing this, we remove the hard dependency we have eeverywhere to our custom errors package. Yes, you can use it as a helper to generate error, but it's still very easy to generate errors without it.
Please, read this fantastic blog post about errors in Go: http://dave.cheney.net/2014/12/24/inspecting-errors
Signed-off-by: David Calavera <david.calavera@gmail.com>
2016-02-25 15:53:35 +00:00
|
|
|
err := fmt.Errorf("%s is a pre-defined network and cannot be removed", nw.Name())
|
2016-05-02 08:54:09 +00:00
|
|
|
return errors.NewRequestForbiddenError(err)
|
2015-12-22 04:35:30 +00:00
|
|
|
}
|
|
|
|
|
|
|
|
if err := nw.Delete(); err != nil {
|
|
|
|
return err
|
|
|
|
}
|
|
|
|
daemon.LogNetworkEvent(nw, "destroy")
|
|
|
|
return nil
|
|
|
|
}
|
2016-03-28 17:41:06 +00:00
|
|
|
|
2016-06-14 02:52:49 +00:00
|
|
|
// GetNetworks returns a list of all networks
|
|
|
|
func (daemon *Daemon) GetNetworks() []libnetwork.Network {
|
|
|
|
return daemon.getAllNetworks()
|
2016-03-28 17:41:06 +00:00
|
|
|
}
|