mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-22 23:50:19 +00:00
75f61fe3d9
This makes most operations thread safe, especially so that they can safely be used in the Kernel. This includes obtaining a strong reference from a weak reference, which now requires an explicit call to WeakPtr::strong_ref(). Another major change is that Weakable::make_weak_ref() may require the explicit target type. Previously we used reinterpret_cast in WeakPtr, assuming that it can be properly converted. But WeakPtr does not necessarily have the knowledge to be able to do this. Instead, we now ask the class itself to deliver a WeakPtr to the type that we want. Also, WeakLink is no longer specific to a target type. The reason for this is that we want to be able to safely convert e.g. WeakPtr<T> to WeakPtr<U>, and before this we just reinterpret_cast the internal WeakLink<T> to WeakLink<U>, which is a bold assumption that it would actually produce the correct code. Instead, WeakLink now operates on just a raw pointer and we only make those constructors/operators available if we can verify that it can be safely cast. In order to guarantee thread safety, we now use the least significant bit in the pointer for locking purposes. This also means that only properly aligned pointers can be used.
134 lines
3.8 KiB
C++
134 lines
3.8 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include <AK/TestSuite.h>
|
|
|
|
#include <AK/NonnullRefPtr.h>
|
|
#include <AK/String.h>
|
|
|
|
struct Object : public RefCounted<Object> {
|
|
int x;
|
|
};
|
|
|
|
struct Object2 : Object {
|
|
};
|
|
|
|
TEST_CASE(basics)
|
|
{
|
|
RefPtr<Object> object = adopt(*new Object);
|
|
EXPECT(object.ptr() != nullptr);
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
object->ref();
|
|
EXPECT_EQ(object->ref_count(), 2u);
|
|
object->unref();
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
|
|
{
|
|
NonnullRefPtr another = *object;
|
|
EXPECT_EQ(object->ref_count(), 2u);
|
|
}
|
|
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
}
|
|
|
|
TEST_CASE(assign_reference)
|
|
{
|
|
RefPtr<Object> object = adopt(*new Object);
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
object = *object;
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
}
|
|
|
|
TEST_CASE(assign_ptr)
|
|
{
|
|
RefPtr<Object> object = adopt(*new Object);
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
object = object.ptr();
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
}
|
|
|
|
TEST_CASE(copy_move_ref)
|
|
{
|
|
RefPtr<Object2> object = adopt(*new Object2);
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
{
|
|
auto object2 = object;
|
|
EXPECT_EQ(object->ref_count(), 2u);
|
|
|
|
RefPtr<Object> object1 = object;
|
|
EXPECT_EQ(object->ref_count(), 3u);
|
|
|
|
object1 = move(object2);
|
|
EXPECT_EQ(object->ref_count(), 2u);
|
|
|
|
RefPtr<Object> object3(move(object1));
|
|
EXPECT_EQ(object3->ref_count(), 2u);
|
|
|
|
object1 = object3;
|
|
EXPECT_EQ(object3->ref_count(), 3u);
|
|
}
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
}
|
|
|
|
TEST_CASE(swap)
|
|
{
|
|
RefPtr<Object> object_a = adopt(*new Object);
|
|
RefPtr<Object> object_b = adopt(*new Object);
|
|
auto* ptr_a = object_a.ptr();
|
|
auto* ptr_b = object_b.ptr();
|
|
swap(object_a, object_b);
|
|
EXPECT_EQ(object_a, ptr_b);
|
|
EXPECT_EQ(object_b, ptr_a);
|
|
EXPECT_EQ(object_a->ref_count(), 1u);
|
|
EXPECT_EQ(object_b->ref_count(), 1u);
|
|
}
|
|
|
|
TEST_CASE(assign_moved_self)
|
|
{
|
|
RefPtr<Object> object = adopt(*new Object);
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
object = move(object);
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
}
|
|
|
|
TEST_CASE(assign_copy_self)
|
|
{
|
|
RefPtr<Object> object = adopt(*new Object);
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
|
|
#ifdef __clang__
|
|
# pragma clang diagnostic push
|
|
# pragma clang diagnostic ignored "-Wself-assign-overloaded"
|
|
#endif
|
|
object = object;
|
|
#ifdef __clang__
|
|
# pragma clang diagnostic pop
|
|
#endif
|
|
|
|
EXPECT_EQ(object->ref_count(), 1u);
|
|
}
|
|
|
|
TEST_MAIN(RefPtr)
|