mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-21 23:20:20 +00:00
7851151cfb
Since the build now happens in Build/$SERENITY_ARCH/ and not in Build/, this updates check-symbols.sh to use the correct directory to check the LibC symbols in. For some reason, the constant failures did not show up as errors in CI.
25 lines
1.2 KiB
Bash
Executable file
25 lines
1.2 KiB
Bash
Executable file
#!/bin/sh
|
|
|
|
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
|
|
cd "$script_path/.." || exit 1
|
|
|
|
# The __cxa_guard_* calls are generated for (non trivial) initialization of local static objects.
|
|
# These symbols are OK to use within serenity code, but they are problematic in LibC because their
|
|
# existence breaks ports (the implementation of these symbols resides in libstdc++.a which we do not link against in ports).
|
|
# To eliminate the need for these symbols, avoid doing non-trivial construction of local statics in LibC.
|
|
|
|
FORBIDDEN_SYMBOLS="__cxa_guard_acquire __cxa_guard_release"
|
|
TARGET="${SERENITY_ARCH:-"i686"}"
|
|
LIBC_PATH="Build/${TARGET}/Userland/Libraries/LibC/libc.a"
|
|
for forbidden_symbol in $FORBIDDEN_SYMBOLS; do
|
|
# check if there's an undefined reference to the symbol & it is not defined anywhere else in the library
|
|
nm "$LIBC_PATH" | grep "U $forbidden_symbol"
|
|
APPEARS_AS_UNDEFINED=$?
|
|
nm "$LIBC_PATH" | grep "T $forbidden_symbol"
|
|
APPEARS_AS_DEFINED=$?
|
|
if [ $APPEARS_AS_UNDEFINED -eq 0 ] && [ ! $APPEARS_AS_DEFINED -eq 0 ]; then
|
|
echo "Forbidden undefined symbol in LibC: $forbidden_symbol"
|
|
echo "See comment in Meta/check-symbols.sh for more info"
|
|
exit 1
|
|
fi
|
|
done
|