mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-22 15:40:19 +00:00
220dd28b02
I have set up a commit.verbose variable in my git config, which shows the patch diff on bottom of the commit message. Unfortunately the character limit was also applied to the diff, which meant that I got a false-positive lint error almost every time.
50 lines
1.6 KiB
Bash
Executable file
50 lines
1.6 KiB
Bash
Executable file
#!/usr/bin/env bash
|
|
|
|
# the file containing the commit message is passed as the first argument
|
|
commit_file="$1"
|
|
commit_message=$(cat "$commit_file")
|
|
|
|
error() {
|
|
echo -e "\033[0;31m$1:\033[0m"
|
|
echo "$commit_message"
|
|
exit 1
|
|
}
|
|
|
|
# fail if the commit message contains windows style line breaks (carriage returns)
|
|
if grep -q -U $'\x0D' "$commit_file"; then
|
|
error "Commit message contains CRLF line breaks (only unix-style LF linebreaks are allowed)"
|
|
fi
|
|
|
|
line_number=0
|
|
while read -r line; do
|
|
# break on git cut line, used by git commit --verbose
|
|
if [[ "$line" == "# ------------------------ >8 ------------------------" ]]; then
|
|
break
|
|
fi
|
|
|
|
# ignore comment lines
|
|
[[ "$line" =~ ^#.* ]] && continue
|
|
|
|
((line_number += 1))
|
|
line_length=${#line}
|
|
|
|
category_pattern="^\S.*?\S: .+"
|
|
if [[ $line_number -eq 1 ]] && (echo "$line" | grep -P -v -q "$category_pattern"); then
|
|
error "Missing category in commit title (if this is a fix up of a previous commit, it should be squashed)"
|
|
fi
|
|
|
|
title_case_pattern="^\S.*?: [A-Z0-9]"
|
|
if [[ $line_number -eq 1 ]] && (echo "$line" | grep -P -v -q "$title_case_pattern"); then
|
|
error "First word of commit after the subsystem is not capitalized"
|
|
fi
|
|
|
|
if [[ $line_number -eq 1 ]] && [[ "$line" =~ \.$ ]]; then
|
|
error "Commit title ends in a period"
|
|
fi
|
|
|
|
url_pattern="([a-z]+:\/\/)?(([a-zA-Z0-9_]|-)+\.)+[a-z]{2,}(:\d+)?([a-zA-Z_0-9@:%\+.~\?&\/=]|-)+"
|
|
if [[ $line_length -gt 72 ]] && (echo "$line" | grep -P -v -q "$url_pattern"); then
|
|
error "Commit message lines are too long (maximum allowed is 72 characters)"
|
|
fi
|
|
done <"$commit_file"
|
|
exit 0
|