mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-12-03 13:00:29 +00:00
cc55732332
Web specs do not return through javascript percent decoded URL path components - but we were doing this in a number of places due to the default behaviour of URL::serialize_path. Since percent encoded URL paths may not contain valid UTF-8 - this was resulting in us crashing in these places. For example - on an HTMLAnchorElement when retrieving the pathname for the URL of: http://ladybird.org/foo%C2%91%91 To fix this make the URL class only return the percent encoded serialized path, matching the URL spec. When the decoded path is required instead explicitly call URL::percent_decode. This fixes a crash running WPT URL tests for the anchor element on: https://wpt.live/url/a-element.html
43 lines
1.1 KiB
C++
43 lines
1.1 KiB
C++
/*
|
|
* Copyright (c) 2021, Dex♪ <dexes.ttp@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibWebSocket/ConnectionInfo.h>
|
|
|
|
namespace WebSocket {
|
|
|
|
ConnectionInfo::ConnectionInfo(URL::URL url)
|
|
: m_url(move(url))
|
|
{
|
|
}
|
|
|
|
bool ConnectionInfo::is_secure() const
|
|
{
|
|
// RFC 6455 Section 3 :
|
|
// The URI is called "secure" if the scheme component matches "wss" case-insensitively.
|
|
return m_url.scheme().bytes_as_string_view().equals_ignoring_ascii_case("wss"sv);
|
|
}
|
|
|
|
ByteString ConnectionInfo::resource_name() const
|
|
{
|
|
// RFC 6455 Section 3 :
|
|
// The "resource-name" can be constructed by concatenating the following:
|
|
StringBuilder builder;
|
|
// "/" if the path component is empty
|
|
auto path = URL::percent_decode(m_url.serialize_path());
|
|
if (path.is_empty())
|
|
builder.append('/');
|
|
// The path component
|
|
builder.append(path);
|
|
// "?" if the query component is non-empty
|
|
if (m_url.query().has_value() && !m_url.query()->is_empty()) {
|
|
builder.append('?');
|
|
// the query component
|
|
builder.append(*m_url.query());
|
|
}
|
|
return builder.to_byte_string();
|
|
}
|
|
|
|
}
|