mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-25 09:00:22 +00:00
1422f7f904
The framebuffer size was reduced in f2c0cee, but this caused some niche
block layouts to write outside of the frame.
This could be fixed by adding checks to see if a block being predicted/
reconstructed is within the frame, but the branches introduced by that
reduce performance slightly. Therefore, it's better to keep the
framebuffer sized according to the decoded frame size in 8x8 blocks so
that any block can be decoded without bounds checking.
A test was added to ensure that this continues to work.
70 lines
2.1 KiB
C++
70 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) 2022, Gregory Bertilson <zaggy1024@gmail.com>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <LibTest/TestCase.h>
|
|
|
|
#include <LibVideo/Containers/Matroska/Reader.h>
|
|
#include <LibVideo/VP9/Decoder.h>
|
|
|
|
static void decode_video(StringView path, size_t expected_frame_count)
|
|
{
|
|
auto matroska_reader = MUST(Video::Matroska::Reader::from_file(path));
|
|
u64 video_track = 0;
|
|
MUST(matroska_reader.for_each_track_of_type(Video::Matroska::TrackEntry::TrackType::Video, [&](Video::Matroska::TrackEntry const& track_entry) -> Video::DecoderErrorOr<IterationDecision> {
|
|
video_track = track_entry.track_number();
|
|
return IterationDecision::Break;
|
|
}));
|
|
VERIFY(video_track != 0);
|
|
|
|
auto iterator = MUST(matroska_reader.create_sample_iterator(video_track));
|
|
size_t frame_count = 0;
|
|
Video::VP9::Decoder vp9_decoder;
|
|
|
|
while (frame_count <= expected_frame_count) {
|
|
auto block_result = iterator.next_block();
|
|
if (block_result.is_error() && block_result.error().category() == Video::DecoderErrorCategory::EndOfStream) {
|
|
VERIFY(frame_count == expected_frame_count);
|
|
return;
|
|
}
|
|
|
|
auto block = block_result.release_value();
|
|
for (auto const& frame : block.frames()) {
|
|
MUST(vp9_decoder.receive_sample(frame));
|
|
while (true) {
|
|
auto frame_result = vp9_decoder.get_decoded_frame();
|
|
if (frame_result.is_error()) {
|
|
if (frame_result.error().category() == Video::DecoderErrorCategory::NeedsMoreInput) {
|
|
break;
|
|
}
|
|
VERIFY_NOT_REACHED();
|
|
}
|
|
}
|
|
frame_count++;
|
|
}
|
|
}
|
|
|
|
VERIFY_NOT_REACHED();
|
|
}
|
|
|
|
TEST_CASE(webm_in_vp9)
|
|
{
|
|
decode_video("./vp9_in_webm.webm"sv, 25);
|
|
}
|
|
|
|
TEST_CASE(vp9_oob_blocks)
|
|
{
|
|
decode_video("./vp9_oob_blocks.webm"sv, 240);
|
|
}
|
|
|
|
BENCHMARK_CASE(vp9_4k)
|
|
{
|
|
decode_video("./vp9_4k.webm"sv, 2);
|
|
}
|
|
|
|
BENCHMARK_CASE(vp9_clamp_reference_mvs)
|
|
{
|
|
decode_video("./vp9_clamp_reference_mvs.webm"sv, 92);
|
|
}
|