mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-25 17:10:23 +00:00
bf7b77e252
When we switched the Bitmap code to operating 32 bits at a time, we neglected to look in the trailing remainder bits after the last full 32-bit word. This patch fixes that and adds a couple of tests for Bitmap that I hacked up while tracking down this bug. I found this bug when noticing that the kernel would OOM while there were still some pages left in the physical page allocator.
364 lines
11 KiB
C++
364 lines
11 KiB
C++
/*
|
|
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/Assertions.h>
|
|
#include <AK/Noncopyable.h>
|
|
#include <AK/Optional.h>
|
|
#include <AK/Platform.h>
|
|
#include <AK/StdLibExtras.h>
|
|
#include <AK/Types.h>
|
|
#include <AK/kmalloc.h>
|
|
|
|
namespace AK {
|
|
|
|
class Bitmap {
|
|
AK_MAKE_NONCOPYABLE(Bitmap)
|
|
public:
|
|
// NOTE: A wrapping Bitmap won't try to free the wrapped data.
|
|
static Bitmap wrap(u8* data, size_t size)
|
|
{
|
|
return Bitmap(data, size);
|
|
}
|
|
|
|
static Bitmap create(size_t size, bool default_value = 0)
|
|
{
|
|
return Bitmap(size, default_value);
|
|
}
|
|
|
|
static Bitmap create()
|
|
{
|
|
return Bitmap();
|
|
}
|
|
|
|
Bitmap(Bitmap&& other)
|
|
{
|
|
m_owned = exchange(other.m_owned, false);
|
|
m_data = exchange(other.m_data, nullptr);
|
|
m_size = exchange(other.m_size, 0);
|
|
}
|
|
|
|
Bitmap& operator=(Bitmap&& other)
|
|
{
|
|
if (this != &other) {
|
|
if (m_owned)
|
|
kfree(m_data);
|
|
m_owned = exchange(other.m_owned, false);
|
|
m_data = exchange(other.m_data, nullptr);
|
|
m_size = exchange(other.m_size, 0);
|
|
}
|
|
return *this;
|
|
}
|
|
|
|
~Bitmap()
|
|
{
|
|
if (m_owned)
|
|
kfree(m_data);
|
|
m_data = nullptr;
|
|
}
|
|
|
|
size_t size() const { return m_size; }
|
|
bool get(size_t index) const
|
|
{
|
|
ASSERT(index < m_size);
|
|
return 0 != (m_data[index / 8] & (1u << (index % 8)));
|
|
}
|
|
void set(size_t index, bool value) const
|
|
{
|
|
ASSERT(index < m_size);
|
|
if (value)
|
|
m_data[index / 8] |= static_cast<u8>((1u << (index % 8)));
|
|
else
|
|
m_data[index / 8] &= static_cast<u8>(~(1u << (index % 8)));
|
|
}
|
|
void set_range(size_t start, size_t len, bool value)
|
|
{
|
|
for (size_t index = start; index < start + len; ++index) {
|
|
set(index, value);
|
|
}
|
|
}
|
|
|
|
u8* data() { return m_data; }
|
|
const u8* data() const { return m_data; }
|
|
|
|
void grow(size_t size, bool default_value)
|
|
{
|
|
ASSERT(size > m_size);
|
|
|
|
auto previous_size_bytes = size_in_bytes();
|
|
auto previous_size = m_size;
|
|
auto previous_data = m_data;
|
|
|
|
m_size = size;
|
|
m_data = reinterpret_cast<u8*>(kmalloc(size_in_bytes()));
|
|
|
|
fill(default_value);
|
|
|
|
if (previous_data != nullptr) {
|
|
__builtin_memcpy(m_data, previous_data, previous_size_bytes);
|
|
if (previous_size % 8)
|
|
set_range(previous_size, 8 - previous_size % 8, default_value);
|
|
kfree(previous_data);
|
|
}
|
|
}
|
|
|
|
void fill(bool value)
|
|
{
|
|
__builtin_memset(m_data, value ? 0xff : 0x00, size_in_bytes());
|
|
}
|
|
|
|
Optional<size_t> find_first_set() const
|
|
{
|
|
size_t i = 0;
|
|
while (i < m_size / 8 && m_data[i] == 0x00)
|
|
i++;
|
|
|
|
for (size_t j = i * 8; j < m_size; j++) {
|
|
if (get(j))
|
|
return j;
|
|
}
|
|
|
|
return {};
|
|
}
|
|
|
|
Optional<size_t> find_first_unset() const
|
|
{
|
|
size_t i = 0;
|
|
while (i < m_size / 8 && m_data[i] == 0xff)
|
|
i++;
|
|
|
|
for (size_t j = i * 8; j < m_size; j++)
|
|
if (!get(j))
|
|
return j;
|
|
|
|
return {};
|
|
}
|
|
|
|
// The function will return the next range of unset bits starting from the
|
|
// @from value.
|
|
// @from: the postition from which the search starts. The var will be
|
|
// changed and new value is the offset of the found block.
|
|
// @min_length: minimum size of the range which will be returned.
|
|
// @max_length: maximum size of the range which will be returned.
|
|
// This is used to increase performance, since the range of
|
|
// unset bits can be long, and we don't need the while range,
|
|
// so we can stop when we've reached @max_length.
|
|
inline Optional<size_t> find_next_range_of_unset_bits(size_t& from, size_t min_length = 1, size_t max_length = max_size) const
|
|
{
|
|
if (min_length > max_length) {
|
|
return {};
|
|
}
|
|
|
|
u32* bitmap32 = (u32*)m_data;
|
|
|
|
// Calculating the start offset.
|
|
size_t start_bucket_index = from / 32;
|
|
size_t start_bucket_bit = from % 32;
|
|
|
|
size_t* start_of_free_chunks = &from;
|
|
size_t free_chunks = 0;
|
|
|
|
for (size_t bucket_index = start_bucket_index; bucket_index < m_size / 32; ++bucket_index) {
|
|
if (bitmap32[bucket_index] == 0xffffffff) {
|
|
// Skip over completely full bucket of size 32.
|
|
if (free_chunks >= min_length) {
|
|
return min(free_chunks, max_length);
|
|
}
|
|
free_chunks = 0;
|
|
start_bucket_bit = 0;
|
|
continue;
|
|
}
|
|
if (bitmap32[bucket_index] == 0x0) {
|
|
// Skip over completely empty bucket of size 32.
|
|
if (free_chunks == 0) {
|
|
*start_of_free_chunks = bucket_index * 32;
|
|
}
|
|
free_chunks += 32;
|
|
if (free_chunks >= max_length) {
|
|
return max_length;
|
|
}
|
|
start_bucket_bit = 0;
|
|
continue;
|
|
}
|
|
|
|
u32 bucket = bitmap32[bucket_index];
|
|
u8 viewed_bits = start_bucket_bit;
|
|
u32 trailing_zeroes = 0;
|
|
|
|
bucket >>= viewed_bits;
|
|
start_bucket_bit = 0;
|
|
|
|
while (viewed_bits < 32) {
|
|
if (bucket == 0) {
|
|
if (free_chunks == 0) {
|
|
*start_of_free_chunks = bucket_index * 32 + viewed_bits;
|
|
}
|
|
free_chunks += 32 - viewed_bits;
|
|
viewed_bits = 32;
|
|
} else {
|
|
trailing_zeroes = count_trailing_zeroes_32(bucket);
|
|
bucket >>= trailing_zeroes;
|
|
|
|
if (free_chunks == 0) {
|
|
*start_of_free_chunks = bucket_index * 32 + viewed_bits;
|
|
}
|
|
free_chunks += trailing_zeroes;
|
|
viewed_bits += trailing_zeroes;
|
|
|
|
if (free_chunks >= min_length) {
|
|
return min(free_chunks, max_length);
|
|
}
|
|
|
|
// Deleting trailing ones.
|
|
u32 trailing_ones = count_trailing_zeroes_32(~bucket);
|
|
bucket >>= trailing_ones;
|
|
viewed_bits += trailing_ones;
|
|
free_chunks = 0;
|
|
}
|
|
}
|
|
}
|
|
|
|
if (free_chunks < min_length) {
|
|
size_t first_trailing_bit = (m_size / 32) * 32;
|
|
size_t trailing_bits = size() % 32;
|
|
for (size_t i = 0; i < trailing_bits; ++i) {
|
|
if (!get(first_trailing_bit + i)) {
|
|
if (!free_chunks)
|
|
*start_of_free_chunks = first_trailing_bit + i;
|
|
if (++free_chunks >= min_length)
|
|
return min(free_chunks, max_length);
|
|
} else {
|
|
free_chunks = 0;
|
|
}
|
|
}
|
|
return {};
|
|
}
|
|
|
|
return min(free_chunks, max_length);
|
|
}
|
|
|
|
Optional<size_t> find_longest_range_of_unset_bits(size_t max_length, size_t& found_range_size) const
|
|
{
|
|
size_t start = 0;
|
|
size_t max_region_start = 0;
|
|
size_t max_region_size = 0;
|
|
|
|
while (true) {
|
|
// Look for the next block which is bigger than currunt.
|
|
auto length_of_found_range = find_next_range_of_unset_bits(start, max_region_size + 1, max_length);
|
|
if (length_of_found_range.has_value()) {
|
|
max_region_start = start;
|
|
max_region_size = length_of_found_range.value();
|
|
start += max_region_size;
|
|
} else {
|
|
// No ranges which are bigger than current were found.
|
|
break;
|
|
}
|
|
}
|
|
|
|
found_range_size = max_region_size;
|
|
if (max_region_size) {
|
|
return max_region_start;
|
|
}
|
|
return {};
|
|
}
|
|
|
|
Optional<size_t> find_first_fit(size_t minimum_length) const
|
|
{
|
|
size_t start = 0;
|
|
auto length_of_found_range = find_next_range_of_unset_bits(start, minimum_length, minimum_length);
|
|
if (length_of_found_range.has_value()) {
|
|
return start;
|
|
}
|
|
return {};
|
|
}
|
|
|
|
Optional<size_t> find_best_fit(size_t minimum_length) const
|
|
{
|
|
size_t start = 0;
|
|
size_t best_region_start = 0;
|
|
size_t best_region_size = max_size;
|
|
bool found = false;
|
|
|
|
while (true) {
|
|
// Look for the next block which is bigger than requested length.
|
|
auto length_of_found_range = find_next_range_of_unset_bits(start, minimum_length, best_region_size);
|
|
if (length_of_found_range.has_value()) {
|
|
if (best_region_size > length_of_found_range.value() || !found) {
|
|
best_region_start = start;
|
|
best_region_size = length_of_found_range.value();
|
|
found = true;
|
|
}
|
|
start += length_of_found_range.value();
|
|
} else {
|
|
// There are no ranges which can fit requested length.
|
|
break;
|
|
}
|
|
}
|
|
|
|
if (found) {
|
|
return best_region_start;
|
|
}
|
|
return {};
|
|
}
|
|
|
|
Bitmap()
|
|
: m_size(0)
|
|
, m_owned(true)
|
|
{
|
|
m_data = nullptr;
|
|
}
|
|
|
|
Bitmap(size_t size, bool default_value)
|
|
: m_size(size)
|
|
, m_owned(true)
|
|
{
|
|
ASSERT(m_size != 0);
|
|
m_data = reinterpret_cast<u8*>(kmalloc(size_in_bytes()));
|
|
fill(default_value);
|
|
}
|
|
|
|
Bitmap(u8* data, size_t size)
|
|
: m_data(data)
|
|
, m_size(size)
|
|
, m_owned(false)
|
|
{
|
|
}
|
|
|
|
static constexpr u32 max_size = 0xffffffff;
|
|
|
|
private:
|
|
size_t size_in_bytes() const { return ceil_div(m_size, static_cast<size_t>(8)); }
|
|
|
|
u8* m_data { nullptr };
|
|
size_t m_size { 0 };
|
|
bool m_owned { false };
|
|
};
|
|
|
|
}
|
|
|
|
using AK::Bitmap;
|