mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-12-03 13:00:29 +00:00
e6f907a155
Problem:
- Many constructors are defined as `{}` rather than using the ` =
default` compiler-provided constructor.
- Some types provide an implicit conversion operator from `nullptr_t`
instead of requiring the caller to default construct. This violates
the C++ Core Guidelines suggestion to declare single-argument
constructors explicit
(https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#c46-by-default-declare-single-argument-constructors-explicit).
Solution:
- Change default constructors to use the compiler-provided default
constructor.
- Remove implicit conversion operators from `nullptr_t` and change
usage to enforce type consistency without conversion.
117 lines
3.5 KiB
C++
117 lines
3.5 KiB
C++
/*
|
|
* Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
|
|
* All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions are met:
|
|
*
|
|
* 1. Redistributions of source code must retain the above copyright notice, this
|
|
* list of conditions and the following disclaimer.
|
|
*
|
|
* 2. Redistributions in binary form must reproduce the above copyright notice,
|
|
* this list of conditions and the following disclaimer in the documentation
|
|
* and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
|
|
* AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
|
|
* IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
|
|
* DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
|
|
* FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
|
|
* DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
|
|
* SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
|
|
* CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
|
|
* OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
|
|
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#pragma once
|
|
|
|
#include <AK/StringView.h>
|
|
#include <AK/Types.h>
|
|
|
|
namespace AK {
|
|
|
|
class Utf8View;
|
|
|
|
class Utf8CodepointIterator {
|
|
friend class Utf8View;
|
|
|
|
public:
|
|
Utf8CodepointIterator() = default;
|
|
~Utf8CodepointIterator() = default;
|
|
|
|
bool operator==(const Utf8CodepointIterator&) const;
|
|
bool operator!=(const Utf8CodepointIterator&) const;
|
|
Utf8CodepointIterator& operator++();
|
|
u32 operator*() const;
|
|
|
|
ssize_t operator-(const Utf8CodepointIterator& other) const
|
|
{
|
|
return m_ptr - other.m_ptr;
|
|
}
|
|
|
|
size_t code_point_length_in_bytes() const;
|
|
bool done() const { return m_length == 0; }
|
|
|
|
private:
|
|
Utf8CodepointIterator(const unsigned char*, size_t);
|
|
const unsigned char* m_ptr { nullptr };
|
|
size_t m_length;
|
|
};
|
|
|
|
class Utf8View {
|
|
public:
|
|
using Iterator = Utf8CodepointIterator;
|
|
|
|
Utf8View() = default;
|
|
explicit Utf8View(const String&);
|
|
explicit Utf8View(const StringView&);
|
|
explicit Utf8View(const char*);
|
|
~Utf8View() = default;
|
|
|
|
const StringView& as_string() const { return m_string; }
|
|
|
|
Utf8CodepointIterator begin() const;
|
|
Utf8CodepointIterator end() const;
|
|
|
|
const unsigned char* bytes() const { return begin_ptr(); }
|
|
int byte_length() const { return m_string.length(); }
|
|
size_t byte_offset_of(const Utf8CodepointIterator&) const;
|
|
Utf8View substring_view(int byte_offset, int byte_length) const;
|
|
bool is_empty() const { return m_string.is_empty(); }
|
|
|
|
size_t iterator_offset(const Utf8CodepointIterator& it) const
|
|
{
|
|
return byte_offset_of(it);
|
|
}
|
|
|
|
bool validate(size_t& valid_bytes) const;
|
|
bool validate() const
|
|
{
|
|
size_t valid_bytes;
|
|
return validate(valid_bytes);
|
|
}
|
|
|
|
size_t length() const
|
|
{
|
|
if (!m_have_length) {
|
|
m_length = calculate_length();
|
|
m_have_length = true;
|
|
}
|
|
return m_length;
|
|
}
|
|
|
|
private:
|
|
const unsigned char* begin_ptr() const;
|
|
const unsigned char* end_ptr() const;
|
|
size_t calculate_length() const;
|
|
|
|
StringView m_string;
|
|
mutable size_t m_length { 0 };
|
|
mutable bool m_have_length { false };
|
|
};
|
|
|
|
}
|
|
|
|
using AK::Utf8CodepointIterator;
|
|
using AK::Utf8View;
|