mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-22 15:40:19 +00:00
10030038e9
We were crashing on the VERIFY_INTERRUPTS_DISABLED() in
RecursiveSpinlock::unlock, which was caused by the compiler reordering
instructions in `sys$get_root_session_id`. In this function, a SpinLock
is locked and quickly unlocked again, and since the lock and unlock
functions were inlined into `sys$get_root_session_id` and the DAIF::read
was missing the `volatile` keyword, the compiler was free to reorder the
reads from the DAIF register to the top of this function. This caused
the CPU to read the interrupts state at the beginning of the function,
and storing the result on the stack, which in turn caused the
VERIFY_INTERRUPTS_DISABLED() assertion to fail. By adding the `volatile`
modifier to the inline assembly, the compiler will not reorder the
instructions.
In aa40cef2b7, I mistakenly assumed that the crash was related to the
initial interrupts state of the kernel threads, but it turns out that
the missing `volatile` keyword was the actual problem. This commit also
removes that code again.
59 lines
1.5 KiB
C++
59 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) 2021, the SerenityOS developers.
|
|
* Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
|
|
*
|
|
* SPDX-License-Identifier: BSD-2-Clause
|
|
*/
|
|
|
|
#include <Kernel/Arch/Processor.h>
|
|
#include <Kernel/Process.h>
|
|
#include <Kernel/Sections.h>
|
|
#include <Kernel/WaitQueue.h>
|
|
#include <Kernel/WorkQueue.h>
|
|
|
|
namespace Kernel {
|
|
|
|
WorkQueue* g_io_work;
|
|
WorkQueue* g_ata_work;
|
|
|
|
UNMAP_AFTER_INIT void WorkQueue::initialize()
|
|
{
|
|
g_io_work = new WorkQueue("IO WorkQueue Task"sv);
|
|
g_ata_work = new WorkQueue("ATA WorkQueue Task"sv);
|
|
}
|
|
|
|
UNMAP_AFTER_INIT WorkQueue::WorkQueue(StringView name)
|
|
{
|
|
auto name_kstring = KString::try_create(name);
|
|
if (name_kstring.is_error())
|
|
TODO();
|
|
auto [_, thread] = Process::create_kernel_process(name_kstring.release_value(), [this] {
|
|
for (;;) {
|
|
WorkItem* item;
|
|
bool have_more;
|
|
m_items.with([&](auto& items) {
|
|
item = items.take_first();
|
|
have_more = !items.is_empty();
|
|
});
|
|
if (item) {
|
|
item->function();
|
|
delete item;
|
|
|
|
if (have_more)
|
|
continue;
|
|
}
|
|
[[maybe_unused]] auto result = m_wait_queue.wait_on({});
|
|
}
|
|
}).release_value_but_fixme_should_propagate_errors();
|
|
m_thread = move(thread);
|
|
}
|
|
|
|
void WorkQueue::do_queue(WorkItem& item)
|
|
{
|
|
m_items.with([&](auto& items) {
|
|
items.append(item);
|
|
});
|
|
m_wait_queue.wake_one();
|
|
}
|
|
|
|
}
|