beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 09:00:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Optimize IsStringWellFormedUnicode using simdutf

Browse source 
`simdutf` has a function for this that is much faster.
This commit is contained in:
Jonne Ransijn 2024-10-26 11:19:58 +02:00 committed by Andreas Kling
parent d2fbbabd89
commit ff6020c207
Notes: github-actions[bot] 2024-10-30 09:29:22 +00:00 
Author: https://github.com/yyny
Commit: https://github.com/LadybirdBrowser/ladybird/commit/ff6020c2073
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1973
1 changed files with 2 additions and 21 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

23
Userland/Libraries/LibJS/Runtime/StringPrototype.cpp
View file

@ -97,27 +97,8 @@ Optional<size_t> string_index_of(Utf16View const& string, Utf16View const& searc
// 7.2.9 Static Semantics: IsStringWellFormedUnicode ( string )
static bool is_string_well_formed_unicode(Utf16View string)
{
// 1. Let strLen be the length of string.
auto length = string.length_in_code_units();
// 2. Let k be 0.
size_t k = 0;
// 3. Repeat, while k ≠ strLen,
while (k != length) {
// a. Let cp be CodePointAt(string, k).
auto code_point = code_point_at(string, k);
// b. If cp.[[IsUnpairedSurrogate]] is true, return false.
if (code_point.is_unpaired_surrogate)
return false;
// c. Set k to k + cp.[[CodeUnitCount]].
k += code_point.code_unit_count;
}
// 4. Return true.
return true;
// OPTIMIZATION: simdutf can do this much faster.
return string.validate();
}
// 11.1.4 CodePointAt ( string, position ), https://tc39.es/ecma262/#sec-codepointat