beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

HexEditor: Gray-out null bytes

Browse source 
This should improve an overall visibility of "meaningful" data. :^)
This commit is contained in:
Karol Kosek 2022-07-10 23:53:23 +02:00 committed by Andreas Kling
parent 8717e78918
commit ff0b4bf360
Notes: sideshowbarker 2024-07-17 09:31:04 +09:00 
Author: https://github.com/krkk
Commit: https://github.com/SerenityOS/serenity/commit/ff0b4bf360
Pull-request: https://github.com/SerenityOS/serenity/pull/14553
1 changed files with 17 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
Userland/Applications/HexEditor/HexEditor.cpp
View file

@ -604,8 +604,17 @@ void HexEditor::paint_event(GUI::PaintEvent& event)
line_height() - m_line_spacing line_height() - m_line_spacing
}; };
const u8 cell_value = m_document->get(byte_position).value;
auto line = String::formatted("{:02X}", cell_value);
Gfx::Color background_color = palette().color(background_role()); Gfx::Color background_color = palette().color(background_role());
Gfx::Color text_color = edited_flag ? Color::Red : palette().color(foreground_role()); Gfx::Color text_color = [&]() -> Gfx::Color {
if (edited_flag)
return Color::Red;
if (cell_value == 0x00)
return palette().color(ColorRole::PlaceholderText);
return palette().color(foreground_role());
}();
if (highlight_flag) { if (highlight_flag) {
background_color = edited_flag ? palette().selection().inverted() : palette().selection(); background_color = edited_flag ? palette().selection().inverted() : palette().selection();
@ -616,8 +625,6 @@ void HexEditor::paint_event(GUI::PaintEvent& event)
} }
painter.fill_rect(hex_display_rect, background_color); painter.fill_rect(hex_display_rect, background_color);
const u8 cell_value = m_document->get(byte_position).value;
auto line = String::formatted("{:02X}", cell_value);
painter.draw_text(hex_display_rect, line, Gfx::TextAlignment::TopLeft, text_color); painter.draw_text(hex_display_rect, line, Gfx::TextAlignment::TopLeft, text_color);
if (m_edit_mode == EditMode::Hex) { if (m_edit_mode == EditMode::Hex) {
@ -640,7 +647,13 @@ void HexEditor::paint_event(GUI::PaintEvent& event)
}; };
background_color = palette().color(background_role()); background_color = palette().color(background_role());
text_color = edited_flag ? Color::Red : palette().color(foreground_role()); text_color = [&]() -> Gfx::Color {
if (edited_flag)
return Color::Red;
if (cell_value == 0x00)
return palette().color(ColorRole::PlaceholderText);
return palette().color(foreground_role());
}();
if (highlight_flag) { if (highlight_flag) {
background_color = edited_flag ? palette().selection().inverted() : palette().selection(); background_color = edited_flag ? palette().selection().inverted() : palette().selection();