beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Oops, the optimization in Vector::append(Vector&&) was broken.

Browse source 
It forgot to clear out the moved-from vector. It's easy to see where this bug
came from: I assumed m_impl was an OwnPtr. It would be comfy if move() on some
arbitrary T* would also null it out but alas that's not how things work.
This commit is contained in:
Andreas Kling 2019-02-11 12:44:01 +01:00
parent 298a49c688
commit fd5136a1ab
Notes: sideshowbarker 2024-07-19 15:47:28 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/fd5136a1ab4
1 changed files with 2 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
AK/Vector.h
View file

@ -173,7 +173,8 @@ public:
void append(Vector<T>&& other)
{
if (!m_impl) {
m_impl = move(other.m_impl);
m_impl = other.m_impl;
other.m_impl = nullptr;
return;
}
Vector<T> tmp = move(other);