beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Remove LegacyOverrideBuiltIns flag from Storage

Browse source 
This was preventing https://ubereats.com/ from fully loading, because
they are attempting to overwrite setItem. They seem to be trying to add
error logging to setItem if it throws, as all they do is add a
try/catch block that emits an error log to their monitoring service if
it throws.

However, because Storage is a legacy platform object with a named
property setter (setItem), it will call setItem with the stringified
version of the function. This is actually expected as per the spec,
Firefox (Gecko) and Epiphany (WebKit) does this too, but Chromium does
not as it actually overwrites the function with the new function and
does not store the stringified function.

The problem is that we had the LegacyOverrideBuiltIns flag accidentally
set, so it would return the stored string instead of the built-in
function (hence the name), then it would try and call it and throw a
"not a function" error. This prevented their JS from going any further.

This fix allows their UI to fully load and be fully interactive, though
it is quite slow at the moment!
This commit is contained in:
Luke Wilde 2024-11-12 12:13:41 +00:00 committed by Jelle Raaijmakers
parent 70ce8046c3
commit faf6fd1189
Notes: github-actions[bot] 2024-11-12 14:35:34 +00:00 
Author: https://github.com/Lubrsi
Commit: https://github.com/LadybirdBrowser/ladybird/commit/faf6fd11894
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2298
Reviewed-by: https://github.com/gmta ✅
3 changed files with 24 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Libraries/LibWeb/HTML/Storage.cpp
View file

@ -28,7 +28,6 @@ Storage::Storage(JS::Realm& realm)
.has_indexed_property_setter = true,
.has_named_property_setter = true,
.has_named_property_deleter = true,
.has_legacy_override_built_ins_interface_extended_attribute = true,
.indexed_property_setter_has_identifier = true,
.named_property_setter_has_identifier = true,
.named_property_deleter_has_identifier = true,

10
Tests/LibWeb/Text/expected/HTML/storage-does-not-have-legacy-override-builtins-flag.txt Normal file
View file

@ -0,0 +1,10 @@
key should still be native: 'function key() { [native code] }'
key's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
getItem should still be native: 'function getItem() { [native code] }'
getItem's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
setItem should still be native: 'function setItem() { [native code] }'
setItem's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
removeItem should still be native: 'function removeItem() { [native code] }'
removeItem's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'
clear should still be native: 'function clear() { [native code] }'
clear's stringified function was added to storage: 'function () { println(`FAIL: Overriden ${functionName} was called`); }'

14
Tests/LibWeb/Text/input/HTML/storage-does-not-have-legacy-override-builtins-flag.html Normal file
View file

@ -0,0 +1,14 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<script>
test(() => {
for (const functionName of ["key", "getItem", "setItem", "removeItem", "clear"]) {
const failFunction = function () { println(`FAIL: Overriden ${functionName} was called`); };
window.localStorage[functionName] = failFunction;
println(`${functionName} should still be native: '${window.localStorage[functionName].toString()}'`);
println(`${functionName}'s stringified function was added to storage: '${window.localStorage.getItem(functionName)}'`);
window.localStorage[functionName]("1", "2");
}
});
</script>