beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

AK: Make all DoublyLinkedList search methods use Traits<T>::equals (#3404)

Browse source
This commit is contained in:
Muhammad Zahalqa 2020-09-05 15:17:14 +03:00 committed by GitHub
parent 02b3cb8123
commit fad0c8e712
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
Notes: sideshowbarker 2024-07-19 02:54:55 +09:00 
Author: https://github.com/tryfinally
Commit: https://github.com/SerenityOS/serenity/commit/fad0c8e712a
Pull-request: https://github.com/SerenityOS/serenity/pull/3404
1 changed files with 17 additions and 14 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

31
AK/DoublyLinkedList.h
View file

@ -74,7 +74,7 @@ private:
};
public:
DoublyLinkedList() {}
DoublyLinkedList() { }
~DoublyLinkedList() { clear(); }
bool is_empty() const { return !head(); }
@ -133,11 +133,7 @@ public:
bool contains_slow(const T& value) const
{
for (auto* node = m_head; node; node = node->next) {
if (node->value == value)
return true;
}
return false;
return find_node(value) != nullptr;
}
using Iterator = DoublyLinkedListIterator<DoublyLinkedList, T>;
@ -152,19 +148,17 @@ public:
ConstIterator find(const T& value) const
{
for (auto* node = m_head; node; node = node->next) {
if (Traits<T>::equals(node->value, value))
return ConstIterator(node);
}
Node* node = find_node(value);
if (node)
return ConstIterator(node);
return end();
}
Iterator find(const T& value)
{
for (auto* node = m_head; node; node = node->next) {
if (Traits<T>::equals(node->value, value))
return Iterator(node);
}
Node* node = find_node(value);
if (node)
return Iterator(node);
return end();
}
@ -220,6 +214,15 @@ private:
m_head = node;
}
Node* find_node(const T& value) const
{
for (auto* node = m_head; node; node = node->next) {
if (Traits<T>::equals(node->value, value))
return node;
}
return nullptr;
}
Node* head() { return m_head; }
const Node* head() const { return m_head; }