beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

StringView: Make construction of String from a StringView containing a String cheaper

Browse source 
... at the cost of an additional pointer per view.
This commit is contained in:
Robin Burchell 2019-06-03 18:27:56 +02:00 committed by Andreas Kling
parent 8fecc0eaee
commit f9ba7adae2
Notes: sideshowbarker 2024-07-19 13:45:40 +09:00 
Author: https://github.com/rburchell
Commit: https://github.com/SerenityOS/serenity/commit/f9ba7adae2e
Pull-request: https://github.com/SerenityOS/serenity/pull/170
Reviewed-by: https://github.com/awesomekling
3 changed files with 9 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
AK/AKString.h
View file

@ -36,9 +36,12 @@ public:
String() {}
String(StringView view)
: m_impl(StringImpl::create(view.characters(), view.length()))
String(const StringView& view)
{
if (view.m_string)
*this = String(*view.m_string);
else
m_impl = StringImpl::create(view.characters(), view.length());
}
String(const String& other)

3
AK/StringView.cpp
View file

@ -4,7 +4,8 @@
namespace AK {
StringView::StringView(const AK::String& string)
: m_characters(string.characters())
: m_string(&string)
, m_characters(string.characters())
, m_length(string.length())
{
}

2
AK/StringView.h
View file

@ -44,6 +44,8 @@ public:
bool operator==(const String&) const;
private:
friend class String;
const AK::String* m_string { nullptr };
const char* m_characters { nullptr };
int m_length { 0 };
};