mirror of
https://github.com/LadybirdBrowser/ladybird.git
synced 2024-11-22 15:40:19 +00:00
Kernel/Storage: Remove redundant reference to a controller in IDEChannel
IDEChannel which is an ATAPort derived class holded a NonnullRefPtr to a parent IDEController, although we can easily defer the usage of it to not be in the IDEChannel code at all, so it allows to keep NonnullRefPtr to the parent ATAController in the ATAPort base class and only there.
This commit is contained in:
parent
0810c1b972
commit
f96e8e97e6
Notes:
sideshowbarker
2024-07-17 08:46:59 +09:00
Author: https://github.com/supercomputer7 Commit: https://github.com/SerenityOS/serenity/commit/f96e8e97e6 Pull-request: https://github.com/SerenityOS/serenity/pull/11081 Reviewed-by: https://github.com/Panky-codes Reviewed-by: https://github.com/linusg ✅
2 changed files with 0 additions and 3 deletions
|
@ -122,7 +122,6 @@ UNMAP_AFTER_INIT IDEChannel::IDEChannel(IDEController const& controller, u8 irq,
|
|||
, IRQHandler(irq)
|
||||
, m_channel_type(type)
|
||||
, m_io_group(io_group)
|
||||
, m_parent_controller(controller)
|
||||
{
|
||||
}
|
||||
|
||||
|
@ -131,7 +130,6 @@ UNMAP_AFTER_INIT IDEChannel::IDEChannel(IDEController const& controller, IOAddre
|
|||
, IRQHandler(type == ChannelType::Primary ? PATA_PRIMARY_IRQ : PATA_SECONDARY_IRQ)
|
||||
, m_channel_type(type)
|
||||
, m_io_group(io_group)
|
||||
, m_parent_controller(controller)
|
||||
{
|
||||
}
|
||||
|
||||
|
|
|
@ -165,6 +165,5 @@ private:
|
|||
bool m_interrupts_enabled { true };
|
||||
|
||||
IOAddressGroup m_io_group;
|
||||
NonnullRefPtr<IDEController> m_parent_controller;
|
||||
};
|
||||
}
|
||||
|
|
Loading…
Reference in a new issue