beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 23:20:20 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Meta: pre-commit should run lint-ports.py only when Ports change

Browse source 
Most of the existing lint-ing shell scripts have the ability
to only run on the files which have actually changed.
The new port lint-ing script doesn't have this functionality
unfortunately. This forces us to lint ALL the ports on every
single change to any other file in the system if you have
the pre-commit hook setup for your git clone locally.

Instead we can use pre-commit's feature to only run a hook
if certain files have changed to reduce the situations in
which we would run the Meta/lint-ports.py script.
This commit is contained in:
Brian Gianforcaro 2021-04-30 04:30:04 -07:00 committed by Linus Groh
parent 7bd796b7e3
commit f91bfe8009
Notes: sideshowbarker 2024-07-18 18:51:48 +09:00 
Author: https://github.com/bgianfo
Commit: https://github.com/SerenityOS/serenity/commit/f91bfe8009f
Pull-request: https://github.com/SerenityOS/serenity/pull/6755
Reviewed-by: https://github.com/linusg
2 changed files with 29 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
.pre-commit-config.yaml
View file

@ -4,4 +4,12 @@ repos:
- id: meta-lint-ci - id: meta-lint-ci
name: Running Meta/lint-ci.sh to ensure changes will pass linting on CI name: Running Meta/lint-ci.sh to ensure changes will pass linting on CI
entry: bash Meta/lint-ci.sh entry: bash Meta/lint-ci.sh
args: [ --no-ports ]
language: system
- id: meta-lint-ports
name: Running Meta/lint-ports.py to ensure changes will pass linting on CI
entry: Meta/lint-ports.py
pass_filenames: false
files: ^Ports/
language: system language: system

22
Meta/lint-ci.sh
View file

@ -5,6 +5,12 @@ set -e
script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P) script_path=$(cd -P -- "$(dirname -- "$0")" && pwd -P)
cd "${script_path}/.." || exit 1 cd "${script_path}/.." || exit 1
ports=true
if [ "$1" == "--no-ports" ]; then
ports=false
shift
fi
RED='\033[0;31m' RED='\033[0;31m'
GREEN='\033[0;32m' GREEN='\033[0;32m'
NC='\033[0m' # No Color NC='\033[0m' # No Color
@ -22,7 +28,6 @@ for cmd in \
Meta/lint-ipc-ids.sh \ Meta/lint-ipc-ids.sh \
Meta/lint-keymaps.py \ Meta/lint-keymaps.py \
Meta/lint-shell-scripts.sh \ Meta/lint-shell-scripts.sh \
Meta/lint-ports.py \
Meta/lint-prettier.sh \ Meta/lint-prettier.sh \
Meta/lint-python.sh; do Meta/lint-python.sh; do
echo "Running ${cmd}... " echo "Running ${cmd}... "
@ -42,6 +47,21 @@ else
((FAILURES+=1)) ((FAILURES+=1))
fi fi
# lint-ports.py is handled separately as it scans all Ports/ all the time.
# This is fine when running lint-ci.sh from the PR validation workflow.
# However when running from the pre-commit workflow it takes an excessive
# amount of time. This condition allows the pre-commit program to detect
# when Ports/ files have changed and only invoke lint-ports.py when needed.
#
if [ "$ports" = true ]; then
if Meta/lint-ports.py; then
echo -e "[${GREEN}OK${NC}]: Meta/lint-ports.py"
else
echo -e "[${RED}FAIL${NC}]: Meta/lint-ports.py"
((FAILURES+=1))
fi
fi
echo "(Not running lint-missing-resources.sh due to high false-positive rate.)" echo "(Not running lint-missing-resources.sh due to high false-positive rate.)"
echo "(Also look out for check-symbols.sh, which can only be executed after the build!)" echo "(Also look out for check-symbols.sh, which can only be executed after the build!)"