beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

HackStudio: Remove the 'Open in a new tab' action

Browse source 
This has become the default with the previous changes so it
doesn't make sense anymore
This commit is contained in:
Marco Cutecchia 2022-09-13 08:14:22 +02:00 committed by Sam Atkins
parent d8b54b7dd0
commit f81b494182
Notes: sideshowbarker 2024-07-17 06:20:29 +09:00 
Author: https://github.com/mrkct
Commit: https://github.com/SerenityOS/serenity/commit/f81b494182
Pull-request: https://github.com/SerenityOS/serenity/pull/15220
Reviewed-by: https://github.com/AtkinsSJ ✅
2 changed files with 0 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Userland/DevTools/HackStudio/HackStudioWidget.cpp
View file

@ -481,7 +481,6 @@ NonnullRefPtr<GUI::Menu> HackStudioWidget::create_project_tree_view_context_menu
m_new_plain_file_action = create_new_file_action("Plain &File", "/res/icons/16x16/new.png", "");
m_open_selected_action = create_open_selected_action();
m_open_selected_in_new_tab_action = create_open_selected_in_new_tab_action();
m_show_in_file_manager_action = create_show_in_file_manager_action();
m_copy_relative_path_action = create_copy_relative_path_action();
m_copy_full_path_action = create_copy_full_path_action();
@ -503,7 +502,6 @@ NonnullRefPtr<GUI::Menu> HackStudioWidget::create_project_tree_view_context_menu
new_file_submenu.add_action(*m_new_directory_action);
project_tree_view_context_menu->add_action(*m_open_selected_action);
project_tree_view_context_menu->add_action(*m_open_selected_in_new_tab_action);
project_tree_view_context_menu->add_action(*m_show_in_file_manager_action);
project_tree_view_context_menu->add_action(*m_copy_relative_path_action);
project_tree_view_context_menu->add_action(*m_copy_full_path_action);
@ -598,20 +596,6 @@ NonnullRefPtr<GUI::Action> HackStudioWidget::create_open_selected_action()
return open_selected_action;
}
NonnullRefPtr<GUI::Action> HackStudioWidget::create_open_selected_in_new_tab_action()
{
auto open_selected_in_new_tab_action = GUI::Action::create("Open in New &Tab", [this](const GUI::Action&) {
auto files = selected_file_paths();
for (auto& file : files) {
add_new_editor(*m_current_editor_tab_widget);
open_file(file);
}
});
open_selected_in_new_tab_action->set_icon(Gfx::Bitmap::try_load_from_file("/res/icons/16x16/open.png"sv).release_value_but_fixme_should_propagate_errors());
open_selected_in_new_tab_action->set_enabled(true);
return open_selected_in_new_tab_action;
}
NonnullRefPtr<GUI::Action> HackStudioWidget::create_show_in_file_manager_action()
{
auto show_in_file_manager_action = GUI::Action::create("Show in File &Manager", [this](const GUI::Action&) {

1
Userland/DevTools/HackStudio/HackStudioWidget.h
View file

@ -220,7 +220,6 @@ private:
RefPtr<GUI::Action> m_new_directory_action;
RefPtr<GUI::Action> m_open_selected_action;
RefPtr<GUI::Action> m_open_selected_in_new_tab_action;
RefPtr<GUI::Action> m_show_in_file_manager_action;
RefPtr<GUI::Action> m_copy_relative_path_action;
RefPtr<GUI::Action> m_copy_full_path_action;