beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Meta: use "better" syntax to set SERENITY_KERNEL_CMDLINE in run.sh :^)

Browse source 
This removes some FIXMEs.

In bash, we could avoid `shift`:
    SERENITY_KERNEL_CMDLINE="${@:2}"

But let's stick to POSIX sh for now.
This commit is contained in:
Emanuele Torre 2020-06-24 03:24:10 +02:00 committed by Andreas Kling
parent 0cee39355c
commit f7f1c3d748
Notes: sideshowbarker 2024-07-19 05:17:31 +09:00 
Author: https://github.com/emanuele6
Commit: https://github.com/SerenityOS/serenity/commit/f7f1c3d7485
Pull-request: https://github.com/SerenityOS/serenity/pull/2617
Reviewed-by: https://github.com/bugaevc
Reviewed-by: https://github.com/ericonr
1 changed files with 4 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
Meta/run.sh
View file

@ -76,12 +76,8 @@ elif [ "$1" = "qgrub" ]; then
-netdev user,id=breh,hostfwd=tcp:127.0.0.1:8888-10.0.2.15:8888,hostfwd=tcp:127.0.0.1:8823-10.0.2.15:23 \
-device e1000,netdev=breh
elif [ "$1" = "q35_cmd" ]; then
SERENITY_KERNEL_CMDLINE=""
# FIXME: Someone who knows sh syntax better, please help:
for _ in $(seq 2 $#); do
shift
SERENITY_KERNEL_CMDLINE="$SERENITY_KERNEL_CMDLINE $1"
done
shift
SERENITY_KERNEL_CMDLINE="$*"
echo "Starting SerenityOS, Commandline: ${SERENITY_KERNEL_CMDLINE}"
# ./run: qemu with SerenityOS with custom commandline
"$SERENITY_QEMU_BIN" \
@ -92,12 +88,8 @@ elif [ "$1" = "q35_cmd" ]; then
-kernel Kernel/Kernel \
-append "${SERENITY_KERNEL_CMDLINE}"
elif [ "$1" = "qcmd" ]; then
SERENITY_KERNEL_CMDLINE=""
# FIXME: Someone who knows sh syntax better, please help:
for _ in $(seq 2 $#); do
shift
SERENITY_KERNEL_CMDLINE="$SERENITY_KERNEL_CMDLINE $1"
done
shift
SERENITY_KERNEL_CMDLINE="$*"
echo "Starting SerenityOS, Commandline: ${SERENITY_KERNEL_CMDLINE}"
# ./run: qemu with SerenityOS with custom commandline
"$SERENITY_QEMU_BIN" \