beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Set key extractability in SubtleCrypto::derive_key()

Browse source 
None of the algorithms actually set the `extractable` internal slot in
their implementations, and looking at `SubtleCrypto::import_key()` it
seems likely that a step is missing here.
This commit is contained in:
Jelle Raaijmakers 2024-11-15 10:36:34 +01:00 committed by Andreas Kling
parent f8c853712e
commit f7993495bd
Notes: github-actions[bot] 2024-11-15 11:32:57 +00:00 
Author: https://github.com/gmta
Commit: https://github.com/LadybirdBrowser/ladybird/commit/f7993495bd5
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/2354
1 changed files with 6 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
Libraries/LibWeb/Crypto/SubtleCrypto.cpp
View file

@ -719,8 +719,13 @@ JS::ThrowCompletionOr<JS::NonnullGCPtr<WebIDL::Promise>> SubtleCrypto::derive_ke
return;
}
// AD-HOC: Set the [[extractable]] internal slot of key to be extractable.
// See: https://github.com/w3c/webcrypto/issues/383
auto key = result.release_value();
key->set_extractable(extractable);
// 17. Resolve promise with result.
WebIDL::resolve_promise(realm, promise, result.release_value());
WebIDL::resolve_promise(realm, promise, key);
}));
return promise;