beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Tests: Pass App Bundle path to WebDriver to WPT CTest test on macOS

Browse source 
The WebDriver binary in ${CMAKE_CURRENT_BINARY_DIR}/bin doesn't actually
have access to the Ladybird binary in the default CMake setup.
This commit is contained in:
Andrew Kaster 2024-02-07 09:10:52 -07:00 committed by Andreas Kling
parent d7f04c9aa1
commit f739e976a4
Notes: sideshowbarker 2024-07-16 19:57:55 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/f739e976a4
Pull-request: https://github.com/SerenityOS/serenity/pull/23110
Issue: https://github.com/SerenityOS/serenity/issues/23067
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Ladybird/CMakeLists.txt
View file

@ -269,4 +269,9 @@ if (BUILD_TESTING)
ENVIRONMENT QT_QPA_PLATFORM=offscreen
ENVIRONMENT "SERENITY_SOURCE_DIR=${SERENITY_SOURCE_DIR}"
)
if (APPLE)
set_tests_properties(LibWeb WPT PROPERTIES
ENVIRONMENT "WEBDRIVER_BINARY=$<TARGET_FILE_DIR:ladybird>/$<TARGET_FILE_NAME:WebDriver>"
)
endif()
endif()

4
Tests/LibWeb/WPT/run.sh
View file

@ -11,8 +11,8 @@ then
fi
WEBDRIVER_BINARY=$(env PATH="${SERENITY_SOURCE_DIR}/Build/lagom/bin:${SERENITY_SOURCE_DIR}/Meta/Lagom/Build/bin:${PATH}" \
which WebDriver)
: "${WEBDRIVER_BINARY:=$(env PATH="${SERENITY_SOURCE_DIR}/Build/lagom/bin:${SERENITY_SOURCE_DIR}/Meta/Lagom/Build/bin:${PATH}" \
which WebDriver)}"
update_expectations_metadata=false
for arg in "$@"; do