beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-27 01:50:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Increase margin in check for stack space limit

Browse source 
test-js crashes with a segmentation fault when running on macOS on Arm.
Increasing the margin in the test in did_reach_stack_space_limit() to
32 * KiB makes the tests pass. To simplify the code, this is applied
independently of platform, and the previous test for use of an address
sanitizer is removed.
This commit is contained in:
Morten Larsen 2022-01-20 13:35:55 +01:00 committed by Idan Horowitz
parent 2ed4e47300
commit f71584b917
Notes: sideshowbarker 2024-07-17 20:33:04 +09:00 
Author: https://github.com/mnlrsn 🔰
Commit: https://github.com/SerenityOS/serenity/commit/f71584b9176
Pull-request: https://github.com/SerenityOS/serenity/pull/12022
Reviewed-by: https://github.com/davidot ✅
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/VM.h
View file

@ -83,11 +83,9 @@ public:
bool did_reach_stack_space_limit() const
{
#ifdef HAS_ADDRESS_SANITIZER
// Address sanitizer (ASAN) used to check for more space but
// currently we can't detect the stack size with it enabled.
return m_stack_info.size_free() < 32 * KiB;
#else
return m_stack_info.size_free() < 16 * KiB;
#endif
}
ThrowCompletionOr<void> push_execution_context(ExecutionContext& context, GlobalObject& global_object)