beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Ensure document.getElementById("") returns null

Browse source 
Previously, if a document had an element whose id was the empty string,
then `document.getElementById("")` and `element.getElementById("")`
would return that element.
This commit is contained in:
Tim Ledbetter 2024-07-22 20:24:03 +01:00 committed by Andreas Kling
parent 18499c4eac
commit f666d967d6
Notes: github-actions[bot] 2024-07-23 06:59:28 +00:00 
Author: https://github.com/tcl3
Commit: https://github.com/LadybirdBrowser/ladybird/commit/f666d967d6b
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/773
3 changed files with 10 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/DOM/getElementById-empty-string.txt Normal file
View file

@ -0,0 +1 @@
document.getElementById(""): null

8
Tests/LibWeb/Text/input/DOM/getElementById-empty-string.html Normal file
View file

@ -0,0 +1,8 @@
<!DOCTYPE html>
<script src="../include.js"></script>
<div id=""></div>
<script>
test(() => {
println(`document.getElementById(""): ${document.getElementById("")}`);
});
</script>

2
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -457,7 +457,7 @@ void Element::attribute_changed(FlyString const& name, Optional<String> const&,
auto value_or_empty = value.value_or(String {});
if (name == HTML::AttributeNames::id) {
if (!value.has_value())
if (value_or_empty.is_empty())
m_id = {};
else
m_id = value_or_empty;