beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 00:50:22 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

AK: Add note about an internal compile error with Optional in GCC 10.3+

Browse source 
This bit me because I accidentally made the destructor for a class which
was wrapped in an Optional private. This causes none of the Optional
destructors to be able to be deduced, which when combined with concepts
causes an internal compile error in GCC 10.3.0+. This commit adds a note
here to make sure that future encounters of this bug does not surprise
people.
This commit is contained in:
sin-ack 2021-09-07 20:46:23 +00:00 committed by Andreas Kling
parent 93ce8fc985
commit f633fb706e
Notes: sideshowbarker 2024-07-18 04:29:20 +09:00 
Author: https://github.com/sin-ack
Commit: https://github.com/SerenityOS/serenity/commit/f633fb706ec
Pull-request: https://github.com/SerenityOS/serenity/pull/9882
1 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
AK/Optional.h
View file

@ -14,6 +14,14 @@
namespace AK {
// NOTE: If you're here because of an internal compiler error in GCC 10.3.0+,
// it's because of the following bug:
//
// https://gcc.gnu.org/bugzilla/show_bug.cgi?id=96745
//
// Make sure you didn't accidentally make your destructor private before
// you start bug hunting. :^)
template<typename T>
class [[nodiscard]] Optional {
public: