beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibCore: Remove unused EventLoopManager::wake()

Browse source 
Only EventLoopImplementation needs to know how to wake up.
This commit is contained in:
Andreas Kling 2023-04-26 19:00:22 +02:00 committed by Sam Atkins
parent 12c73915dc
commit f61947fa9e
Notes: sideshowbarker 2024-07-17 02:22:23 +09:00 
Author: https://github.com/awesomekling
Commit: https://github.com/SerenityOS/serenity/commit/f61947fa9e
Pull-request: https://github.com/SerenityOS/serenity/pull/18521
Reviewed-by: https://github.com/trflynn89 ✅
5 changed files with 0 additions and 16 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Ladybird/EventLoopImplementationQt.cpp
View file

@ -165,10 +165,6 @@ EventLoopManagerQt::EventLoopManagerQt()
EventLoopManagerQt::~EventLoopManagerQt() = default; EventLoopManagerQt::~EventLoopManagerQt() = default;
void EventLoopManagerQt::wake()
{
}
NonnullOwnPtr<Core::EventLoopImplementation> EventLoopManagerQt::make_implementation() NonnullOwnPtr<Core::EventLoopImplementation> EventLoopManagerQt::make_implementation()
{ {
return adopt_own(*new EventLoopImplementationQt); return adopt_own(*new EventLoopImplementationQt);

2
Ladybird/EventLoopImplementationQt.h
View file

@ -30,8 +30,6 @@ public:
virtual void did_post_event() override; virtual void did_post_event() override;
virtual void wake() override;
// FIXME: These APIs only exist for obscure use-cases inside SerenityOS. Try to get rid of them. // FIXME: These APIs only exist for obscure use-cases inside SerenityOS. Try to get rid of them.
virtual int register_signal(int, Function<void(int)>) override { return 0; } virtual int register_signal(int, Function<void(int)>) override { return 0; }
virtual void unregister_signal(int) override { } virtual void unregister_signal(int) override { }

2
Userland/Libraries/LibCore/EventLoopImplementation.h
View file

@ -35,8 +35,6 @@ public:
virtual int register_signal(int signal_number, Function<void(int)> handler) = 0; virtual int register_signal(int signal_number, Function<void(int)> handler) = 0;
virtual void unregister_signal(int handler_id) = 0; virtual void unregister_signal(int handler_id) = 0;
virtual void wake() = 0;
protected: protected:
EventLoopManager(); EventLoopManager();
}; };

6
Userland/Libraries/LibCore/EventLoopImplementationUnix.cpp
View file

@ -139,12 +139,6 @@ void EventLoopImplementationUnix::wake()
MUST(Core::System::write((*m_wake_pipe_fds)[1], { &wake_event, sizeof(wake_event) })); MUST(Core::System::write((*m_wake_pipe_fds)[1], { &wake_event, sizeof(wake_event) }));
} }
void EventLoopManagerUnix::wake()
{
int wake_event = 0;
MUST(Core::System::write(ThreadData::the().wake_pipe_fds[1], { &wake_event, sizeof(wake_event) }));
}
void EventLoopManagerUnix::wait_for_events(EventLoopImplementation::PumpMode mode) void EventLoopManagerUnix::wait_for_events(EventLoopImplementation::PumpMode mode)
{ {
auto& thread_data = ThreadData::the(); auto& thread_data = ThreadData::the();

2
Userland/Libraries/LibCore/EventLoopImplementationUnix.h
View file

@ -27,8 +27,6 @@ public:
virtual int register_signal(int signal_number, Function<void(int)> handler) override; virtual int register_signal(int signal_number, Function<void(int)> handler) override;
virtual void unregister_signal(int handler_id) override; virtual void unregister_signal(int handler_id) override;
virtual void wake() override;
void wait_for_events(EventLoopImplementation::PumpMode); void wait_for_events(EventLoopImplementation::PumpMode);
static Optional<Time> get_next_timer_expiration(); static Optional<Time> get_next_timer_expiration();