beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-27 01:50:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

PixelPaint: Fix incorrect use of RefCounted CRTP

Browse source 
I'm not even sure why this worked. How would the compiler know which
type to destruct the FilterInfo object as?

Fixes this janky error from gcc 12:

AK/RefCounted.h:70:13: error: array subscript 0 is outside array bounds
of 'void [56]' [-Werror=array-bounds]
   70 |             delete static_cast<const T*>(this);
      |             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This commit is contained in:
Daniel Bertalan 2022-05-07 17:20:02 +02:00 committed by Andreas Kling
parent 699bd9afc6
commit f40b6fbd07
Notes: sideshowbarker 2024-07-17 17:06:59 +09:00 
Author: https://github.com/BertalanD
Commit: https://github.com/SerenityOS/serenity/commit/f40b6fbd07
Pull-request: https://github.com/SerenityOS/serenity/pull/13954
Reviewed-by: https://github.com/ADKaster
Reviewed-by: https://github.com/EWouters
Reviewed-by: https://github.com/timschumi ✅
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/PixelPaint/FilterModel.h
View file

@ -16,7 +16,7 @@ namespace PixelPaint {
class FilterModel final : public GUI::Model {
public:
class FilterInfo : public RefCounted {
class FilterInfo : public RefCounted<FilterInfo> {
public:
enum class Type {
Category,