beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-25 17:10:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

IPCCompiler: Use GENERATE_DEBUG from AK/Debug instead of custom defines

Browse source 
The IPCCompiler was using GENERATE_DEBUG_CODE, which was missing from
AK/Debug.h.in, and plain old DEBUG. Let's just use the one that
was already in the debug header, but unused.
This commit is contained in:
Andrew Kaster 2021-07-12 01:32:46 -06:00 committed by Andreas Kling
parent 6ba87a6b5e
commit f26d4e1d90
Notes: sideshowbarker 2024-07-18 09:12:01 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/f26d4e1d90b
Pull-request: https://github.com/SerenityOS/serenity/pull/8675
Reviewed-by: https://github.com/gunnarbeutner ✅
1 changed files with 21 additions and 25 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

46
Userland/DevTools/IPCCompiler/main.cpp
View file

@ -14,10 +14,6 @@
#include <ctype.h> #include <ctype.h>
#include <stdio.h> #include <stdio.h>
#ifndef GENERATE_DEBUG_CODE
# define GENERATE_DEBUG_CODE 0
#endif
struct Parameter { struct Parameter {
Vector<String> attributes; Vector<String> attributes;
String type; String type;
@ -666,7 +662,7 @@ public:
stream >> message_endpoint_magic; stream >> message_endpoint_magic;
if (stream.handle_any_error()) { if (stream.handle_any_error()) {
)~~~"); )~~~");
if constexpr (GENERATE_DEBUG_CODE) { if constexpr (GENERATE_DEBUG) {
endpoint_generator.append(R"~~~( endpoint_generator.append(R"~~~(
dbgln("Failed to read message endpoint magic"); dbgln("Failed to read message endpoint magic");
)~~~"); )~~~");
@ -677,7 +673,7 @@ public:
if (message_endpoint_magic != @endpoint.magic@) { if (message_endpoint_magic != @endpoint.magic@) {
)~~~"); )~~~");
if constexpr (GENERATE_DEBUG_CODE) { if constexpr (GENERATE_DEBUG) {
endpoint_generator.append(R"~~~( endpoint_generator.append(R"~~~(
dbgln("@endpoint.name@: Endpoint magic number message_endpoint_magic != @endpoint.magic@, not my message! (the other endpoint may have handled it)"); dbgln("@endpoint.name@: Endpoint magic number message_endpoint_magic != @endpoint.magic@, not my message! (the other endpoint may have handled it)");
)~~~"); )~~~");
@ -690,7 +686,7 @@ public:
stream >> message_id; stream >> message_id;
if (stream.handle_any_error()) { if (stream.handle_any_error()) {
)~~~"); )~~~");
if constexpr (GENERATE_DEBUG_CODE) { if constexpr (GENERATE_DEBUG) {
endpoint_generator.append(R"~~~( endpoint_generator.append(R"~~~(
dbgln("Failed to read message ID"); dbgln("Failed to read message ID");
)~~~"); )~~~");
@ -725,7 +721,7 @@ public:
endpoint_generator.append(R"~~~( endpoint_generator.append(R"~~~(
default: default:
)~~~"); )~~~");
if constexpr (GENERATE_DEBUG_CODE) { if constexpr (GENERATE_DEBUG) {
endpoint_generator.append(R"~~~( endpoint_generator.append(R"~~~(
dbgln("Failed to decode @endpoint.name@.({})", message_id); dbgln("Failed to decode @endpoint.name@.({})", message_id);
)~~~"); )~~~");
@ -736,7 +732,7 @@ public:
if (stream.handle_any_error()) { if (stream.handle_any_error()) {
)~~~"); )~~~");
if constexpr (GENERATE_DEBUG_CODE) { if constexpr (GENERATE_DEBUG) {
endpoint_generator.append(R"~~~( endpoint_generator.append(R"~~~(
dbgln("Failed to read the message"); dbgln("Failed to read the message");
)~~~"); )~~~");
@ -879,25 +875,25 @@ private:
outln("{}", generator.as_string_view()); outln("{}", generator.as_string_view());
#ifdef DEBUG if constexpr (GENERATE_DEBUG) {
for (auto& endpoint : endpoints) { for (auto& endpoint : endpoints) {
warnln("Endpoint '{}' (magic: {})", endpoint.name, endpoint.magic); warnln("Endpoint '{}' (magic: {})", endpoint.name, endpoint.magic);
for (auto& message : endpoint.messages) { for (auto& message : endpoint.messages) {
warnln(" Message: '{}'", message.name); warnln(" Message: '{}'", message.name);
warnln(" Sync: {}", message.is_synchronous); warnln(" Sync: {}", message.is_synchronous);
warnln(" Inputs:"); warnln(" Inputs:");
for (auto& parameter : message.inputs) for (auto& parameter : message.inputs)
warnln(" Parameter: {} ({})", parameter.name, parameter.type);
if (message.inputs.is_empty())
warnln(" (none)");
if (message.is_synchronous) {
warnln(" Outputs:");
for (auto& parameter : message.outputs)
warnln(" Parameter: {} ({})", parameter.name, parameter.type); warnln(" Parameter: {} ({})", parameter.name, parameter.type);
if (message.outputs.is_empty()) if (message.inputs.is_empty())
warnln(" (none)"); warnln(" (none)");
if (message.is_synchronous) {
warnln(" Outputs:");
for (auto& parameter : message.outputs)
warnln(" Parameter: {} ({})", parameter.name, parameter.type);
if (message.outputs.is_empty())
warnln(" (none)");
}
} }
} }
} }
#endif
} }