beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 23:50:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibC: Sync file position when dropping read ahead buffer

Browse source 
When we flush a FILE, we behave differently depending on whether we reading from
the file or writing to it:

* If we're writing, we actually write out the buffered data.
* If we're reading, we just drop the buffered (read ahead) data.

After flushing, there should be no additional buffered state stdio keeps about a
FILE, compared to what is true about the underlying file. This includes file
position (offset). When flushing writes, this is taken care of automatically,
but dropping the buffer is not enough to achieve that when reading. This commit
fixes that by seeking back explicitly in that case.

One way the problem manifested itself was upon fseek(SEEK_CUR) calls, as the
position of the underlying file was oftentimes different to the logical position
of the FILE. Since FILE::seek() already calls FILE::flush() prior to actually
modifying the position, fixing FILE::flush() to sync the positions is enough to
fix that issue.
This commit is contained in:
Sergey Bugaev 2020-05-22 19:35:47 +03:00 committed by Andreas Kling
parent 799f6f4ec6
commit f03e452085
Notes: sideshowbarker 2024-07-19 06:15:02 +09:00 
Author: https://github.com/bugaevc
Commit: https://github.com/SerenityOS/serenity/commit/f03e4520853
Pull-request: https://github.com/SerenityOS/serenity/pull/2331
Reviewed-by: https://github.com/awesomekling
1 changed files with 27 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

27
Libraries/LibC/stdio.cpp
View file

@ -92,6 +92,7 @@ private:
bool may_use() const { return m_ungotten || m_mode != _IONBF; }
bool is_not_empty() const { return m_ungotten || !m_empty; }
size_t buffered_size() const;
const u8* begin_dequeue(size_t& available_size) const;
void did_dequeue(size_t actual_size);
@ -172,7 +173,20 @@ bool FILE::flush()
}
if (m_mode & O_RDONLY) {
// When open for reading, just drop the buffered data.
size_t had_buffered = m_buffer.buffered_size();
m_buffer.drop();
// Attempt to reset the underlying file position to what the user
// expects.
int rc = lseek(m_fd, -had_buffered, SEEK_CUR);
if (rc < 0) {
if (errno == ESPIPE) {
// We can't set offset on this file; oh well, the user will just
// have to cope.
errno = 0;
} else {
return false;
}
}
}
return true;
@ -440,6 +454,19 @@ void FILE::Buffer::drop()
m_ungotten = false;
}
size_t FILE::Buffer::buffered_size() const
{
// Note: does not include the ungetc() buffer.
if (m_empty)
return 0;
if (m_begin < m_end)
return m_end - m_begin;
else
return m_capacity - (m_begin - m_end);
}
const u8* FILE::Buffer::begin_dequeue(size_t& available_size) const
{
if (m_ungotten) {