beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-29 02:50:26 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Don't infinite loop on unknown console.log formatting specifiers

Browse source
This commit is contained in:
Andreas Kling 2024-09-26 07:42:49 +02:00 committed by Andreas Kling
parent 84351dfa51
commit ef9208047d
Notes: github-actions[bot] 2024-09-26 08:15:20 +00:00 
Author: https://github.com/awesomekling
Commit: https://github.com/LadybirdBrowser/ladybird/commit/ef9208047dc
Pull-request: https://github.com/LadybirdBrowser/ladybird/pull/1537
3 changed files with 9 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/regress/console-log-bogus-formatting-specifier.txt Normal file
View file

@ -0,0 +1 @@
PASS (didn't hang)

7
Tests/LibWeb/Text/input/regress/console-log-bogus-formatting-specifier.html Normal file
View file

@ -0,0 +1,7 @@
<script src="../include.js"></script>
<script>
test(() => {
console.log("%z%z", 1, 2);
println("PASS (didn't hang)");
});
</script>

2
Userland/Libraries/LibJS/Console.cpp
View file

@ -818,7 +818,7 @@ ThrowCompletionOr<MarkedVector<Value>> ConsoleClient::formatter(MarkedVector<Val
auto find_specifier = [](StringView target) -> Optional<StringView> { auto find_specifier = [](StringView target) -> Optional<StringView> {
size_t start_index = 0; size_t start_index = 0;
while (start_index < target.length()) { while (start_index < target.length()) {
auto maybe_index = target.find('%'); auto maybe_index = target.find('%', start_index);
if (!maybe_index.has_value()) if (!maybe_index.has_value())
return {}; return {};