beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibDebug: Factor out the "looks like embedded resource" condition

Browse source
This commit is contained in:
Tim Schumacher 2023-01-12 14:07:27 +01:00 committed by Jelle Raaijmakers
parent afc055c088
commit edd4913573
Notes: sideshowbarker 2024-07-17 07:20:57 +09:00 
Author: https://github.com/timschumi
Commit: https://github.com/SerenityOS/serenity/commit/edd4913573
Pull-request: https://github.com/SerenityOS/serenity/pull/16971
Reviewed-by: https://github.com/gmta ✅
3 changed files with 8 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibDebug/Dwarf/DwarfInfo.cpp
View file

@ -65,7 +65,7 @@ void DwarfInfo::populate_compilation_units()
// Meaning that for graphical applications, some line info data would be unread, triggering the assertion below. // Meaning that for graphical applications, some line info data would be unread, triggering the assertion below.
// As a fix, we don't create compilation units for line programs that come from resource files. // As a fix, we don't create compilation units for line programs that come from resource files.
#if defined(AK_COMPILER_CLANG) #if defined(AK_COMPILER_CLANG)
if (line_program->source_files().size() == 1 && line_program->source_files()[0].name.view().contains("serenity_icon_"sv)) { if (line_program->looks_like_embedded_resource()) {
debug_info_stream.seek(unit_offset); debug_info_stream.seek(unit_offset);
} else } else
#endif #endif

5
Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp
View file

@ -306,4 +306,9 @@ LineProgram::DirectoryAndFile LineProgram::get_directory_and_file(size_t file_in
return { directory_entry, file_entry.name }; return { directory_entry, file_entry.name };
} }
bool LineProgram::looks_like_embedded_resource() const
{
return source_files().size() == 1 && source_files()[0].name.view().contains("serenity_icon_"sv);
}
} }

2
Userland/Libraries/LibDebug/Dwarf/LineProgram.h
View file

@ -130,6 +130,8 @@ public:
}; };
Vector<FileEntry> const& source_files() const { return m_source_files; } Vector<FileEntry> const& source_files() const { return m_source_files; }
bool looks_like_embedded_resource() const;
private: private:
void parse_unit_header(); void parse_unit_header();
void parse_source_directories(); void parse_source_directories();