beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibGUI+Everywhere: Rename the 'style' frame property to 'frame_style'

Browse source 
'set_frame_style' is what Frame itself uses to set the value, and a
significant number of GML files use 'frame_style' instead of just
'style', so let's switch to it and use it everywhere consistently.
This commit is contained in:
Ali Mohammad Pur 2024-04-24 15:10:52 +02:00 committed by Andrew Kaster
parent f3a4118aee
commit eaa2d69d73
Notes: sideshowbarker 2024-07-17 01:21:02 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/eaa2d69d73
Pull-request: https://github.com/SerenityOS/serenity/pull/24098
Reviewed-by: https://github.com/ADKaster ✅
9 changed files with 11 additions and 12 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Applications/Browser/Tab.gml
View file

@ -13,7 +13,7 @@
@GUI::Frame {
name: "webdriver_banner"
style: "SunkenPanel"
frame_style: "SunkenPanel"
preferred_height: "shrink"
foreground_role: "TooltipText"
background_role: "Tooltip"

2
Userland/Applications/ClockSettings/ClockSettingsWidget.gml
View file

@ -63,7 +63,7 @@
}
@GUI::Label {
style: "SunkenContainer"
frame_style: "SunkenContainer"
name: "clock_preview"
text: "12:34:56"
}

6
Userland/Applications/DisplaySettings/FontSettings.gml
View file

@ -19,7 +19,7 @@
@GUI::Label {
background_role: "Base"
style: "SunkenContainer"
frame_style: "SunkenContainer"
fill_with_background_color: true
name: "default_font_label"
}
@ -45,7 +45,7 @@
@GUI::Label {
background_role: "Base"
style: "SunkenContainer"
frame_style: "SunkenContainer"
fill_with_background_color: true
name: "window_title_font_label"
}
@ -71,7 +71,7 @@
@GUI::Label {
background_role: "Base"
style: "SunkenContainer"
frame_style: "SunkenContainer"
fill_with_background_color: true
name: "fixed_width_font_label"
}

2
Userland/Applications/FontEditor/FontPreviewWindow.gml
View file

@ -8,7 +8,7 @@
layout: @GUI::VerticalBoxLayout {
margins: [4]
}
style: "SunkenBox"
frame_style: "SunkenBox"
@GUI::Label {
name: "preview_label"

2
Userland/Demos/WidgetGallery/GalleryGML/BasicsTab.gml
View file

@ -17,7 +17,7 @@
@GUI::Frame {
name: "label_frame"
style: "SunkenPanel"
frame_style: "SunkenPanel"
layout: @GUI::VerticalBoxLayout {
margins: [3, 4]
}

2
Userland/Demos/WidgetGallery/GalleryGML/SlidersTab.gml
View file

@ -35,7 +35,7 @@
@GUI::HorizontalSeparator {}
@GUI::Frame {
style: "SunkenPanel"
frame_style: "SunkenPanel"
preferred_height: "fit"
layout: @GUI::VerticalBoxLayout {
margins: [1]

4
Userland/DevTools/HackStudio/Dialogs/NewProjectDialog.gml
View file

@ -18,7 +18,7 @@
@GUI::Label {
name: "description_label"
text_alignment: "CenterLeft"
style: "SunkenContainer"
frame_style: "SunkenContainer"
max_height: 24
}
@ -73,7 +73,7 @@
name: "full_path_label"
text_alignment: "CenterLeft"
text: ""
style: "SunkenContainer"
frame_style: "SunkenContainer"
max_height: 22
}
}

1
Userland/Libraries/LibGUI/EmojiInputDialog.gml
View file

@ -23,7 +23,6 @@
@GUI::ScrollableContainerWidget {
name: "scrollable_container"
content_widget: @GUI::Widget {
name: "emojis"
layout: @GUI::VerticalBoxLayout {}

2
Userland/Libraries/LibGUI/Frame.cpp
View file

@ -19,7 +19,7 @@ Frame::Frame()
{
set_frame_style(Gfx::FrameStyle::SunkenContainer);
REGISTER_ENUM_PROPERTY("style", frame_style, set_frame_style, Gfx::FrameStyle,
REGISTER_ENUM_PROPERTY("frame_style", frame_style, set_frame_style, Gfx::FrameStyle,
{ Gfx::FrameStyle::NoFrame, "NoFrame" },
{ Gfx::FrameStyle::Window, "Window" },
{ Gfx::FrameStyle::Plain, "Plain" },