beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 09:30:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibWeb: Port Worker to new String

Browse source
This commit is contained in:
Kenneth Myhra 2023-02-23 12:40:07 +01:00 committed by Sam Atkins
parent 836cb73d29
commit e905f25911
Notes: sideshowbarker 2024-07-17 09:49:48 +09:00 
Author: https://github.com/kennethmyhra
Commit: https://github.com/SerenityOS/serenity/commit/e905f25911
Pull-request: https://github.com/SerenityOS/serenity/pull/17577
Reviewed-by: https://github.com/AtkinsSJ
3 changed files with 11 additions and 11 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/HTML/Worker.cpp
View file

@ -17,7 +17,7 @@
namespace Web::HTML {
// https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-worker-interface
Worker::Worker(DeprecatedFlyString const& script_url, WorkerOptions const options, DOM::Document& document)
Worker::Worker(String const& script_url, WorkerOptions const options, DOM::Document& document)
: DOM::EventTarget(document.realm())
, m_script_url(script_url)
, m_options(options)
@ -47,7 +47,7 @@ void Worker::visit_edges(Cell::Visitor& visitor)
}
// https://html.spec.whatwg.org/multipage/workers.html#dom-worker
WebIDL::ExceptionOr<JS::NonnullGCPtr<Worker>> Worker::create(DeprecatedFlyString const& script_url, WorkerOptions const options, DOM::Document& document)
WebIDL::ExceptionOr<JS::NonnullGCPtr<Worker>> Worker::create(String const& script_url, WorkerOptions const options, DOM::Document& document)
{
dbgln_if(WEB_WORKER_DEBUG, "WebWorker: Creating worker with script_url = {}", script_url);
@ -66,7 +66,7 @@ WebIDL::ExceptionOr<JS::NonnullGCPtr<Worker>> Worker::create(DeprecatedFlyString
auto& outside_settings = document.relevant_settings_object();
// 3. Parse the scriptURL argument relative to outside settings.
auto url = document.parse_url(script_url);
auto url = document.parse_url(script_url.to_deprecated_string());
// 4. If this fails, throw a "SyntaxError" DOMException.
if (!url.is_valid()) {

14
Userland/Libraries/LibWeb/HTML/Worker.h
View file

@ -26,9 +26,9 @@
namespace Web::HTML {
struct WorkerOptions {
DeprecatedString type { "classic" };
DeprecatedString credentials { "same-origin" };
DeprecatedString name { "" };
String type { String::from_utf8("classic"sv).release_value_but_fixme_should_propagate_errors() };
String credentials { String::from_utf8("same-origin"sv).release_value_but_fixme_should_propagate_errors() };
String name { String {} };
};
// https://html.spec.whatwg.org/multipage/workers.html#dedicated-workers-and-the-worker-interface
@ -36,8 +36,8 @@ class Worker : public DOM::EventTarget {
WEB_PLATFORM_OBJECT(Worker, DOM::EventTarget);
public:
static WebIDL::ExceptionOr<JS::NonnullGCPtr<Worker>> create(DeprecatedFlyString const& script_url, WorkerOptions const options, DOM::Document& document);
static WebIDL::ExceptionOr<JS::NonnullGCPtr<Worker>> construct_impl(JS::Realm& realm, DeprecatedFlyString const& script_url, WorkerOptions const options)
static WebIDL::ExceptionOr<JS::NonnullGCPtr<Worker>> create(String const& script_url, WorkerOptions const options, DOM::Document& document);
static WebIDL::ExceptionOr<JS::NonnullGCPtr<Worker>> construct_impl(JS::Realm& realm, String const& script_url, WorkerOptions const options)
{
auto& window = verify_cast<HTML::Window>(realm.global_object());
return Worker::create(script_url, options, window.associated_document());
@ -60,7 +60,7 @@ public:
#undef __ENUMERATE
protected:
Worker(DeprecatedFlyString const&, const WorkerOptions, DOM::Document&);
Worker(String const&, const WorkerOptions, DOM::Document&);
private:
static HTML::EventLoop& get_vm_event_loop(JS::VM& target_vm)
@ -71,7 +71,7 @@ private:
virtual JS::ThrowCompletionOr<void> initialize(JS::Realm&) override;
virtual void visit_edges(Cell::Visitor&) override;
DeprecatedFlyString m_script_url;
String m_script_url;
WorkerOptions m_options;
JS::GCPtr<DOM::Document> m_document;

2
Userland/Libraries/LibWeb/HTML/Worker.idl
View file

@ -1,7 +1,7 @@
#import <DOM/EventTarget.idl>
#import <DOM/EventHandler.idl>
[Exposed=(Window)]
[Exposed=(Window), UseNewAKString]
interface Worker : EventTarget {
constructor(DOMString scriptURL, optional WorkerOptions options = {});