beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 15:40:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibTLS: Remove outdated comment about ECC

Browse source 
PR #18166 introduced the ability to parse ECC certificates. If we
now fail here the reason is mostlikely something new and we should
prevent this rabbit hole from happening.
This commit is contained in:
Fabian Dellwing 2023-04-10 07:06:51 +02:00 committed by Ali Mohammad Pur
parent 93232d4e6d
commit e78db6417a
Notes: sideshowbarker 2024-07-17 04:09:56 +09:00 
Author: https://github.com/fdellwing
Commit: https://github.com/SerenityOS/serenity/commit/e78db6417a
Pull-request: https://github.com/SerenityOS/serenity/pull/18203
Reviewed-by: https://github.com/gmta
1 changed files with 0 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibTLS/TLSv12.cpp
View file

@ -521,8 +521,6 @@ ErrorOr<Vector<Certificate>> DefaultRootCACertificates::parse_pem_root_certifica
for (auto& cert : certs) {
auto certificate_result = Certificate::parse_certificate(cert.bytes());
// If the certificate does not parse it is likely using elliptic curve keys/signatures, which are not
// supported right now. It might make sense to cleanup cacert.pem before adding it to the system.
if (certificate_result.is_error()) {
// FIXME: It would be nice to have more informations about the certificate we failed to parse.
// Like: Issuer, Algorithm, CN, etc