beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-27 01:50:24 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 7

LibJS: Make basic block size customizable

Browse source 
And keep the default 4 KiB for the code generator.
This commit is contained in:
Ali Mohammad Pur 2021-06-12 20:36:39 +04:30 committed by Ali Mohammad Pur
parent f7f88adc78
commit e73b142a97
Notes: sideshowbarker 2024-07-18 12:13:20 +09:00 
Author: https://github.com/alimpfard
Commit: https://github.com/SerenityOS/serenity/commit/e73b142a97d
Pull-request: https://github.com/SerenityOS/serenity/pull/8023
Reviewed-by: https://github.com/awesomekling
2 changed files with 7 additions and 6 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Bytecode/BasicBlock.cpp
View file

@ -11,18 +11,18 @@
namespace JS::Bytecode {
NonnullOwnPtr<BasicBlock> BasicBlock::create(String name)
NonnullOwnPtr<BasicBlock> BasicBlock::create(String name, size_t size)
{
return adopt_own(*new BasicBlock(move(name)));
return adopt_own(*new BasicBlock(move(name), max(size, static_cast<size_t>(4 * KiB))));
}
BasicBlock::BasicBlock(String name)
BasicBlock::BasicBlock(String name, size_t size)
: m_name(move(name))
{
// FIXME: This is not the smartest solution ever. Find something cleverer!
// The main issue we're working around here is that we don't want pointers into the bytecode stream to become invalidated
// during code generation due to dynamic buffer resizing. Otherwise we could just use a Vector.
m_buffer_capacity = 4 * KiB;
m_buffer_capacity = size;
m_buffer = (u8*)mmap(nullptr, m_buffer_capacity, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
VERIFY(m_buffer != MAP_FAILED);
}

5
Userland/Libraries/LibJS/Bytecode/BasicBlock.h
View file

@ -47,13 +47,14 @@ class BasicBlock {
AK_MAKE_NONCOPYABLE(BasicBlock);
public:
static NonnullOwnPtr<BasicBlock> create(String name);
static NonnullOwnPtr<BasicBlock> create(String name, size_t size = 4 * KiB);
~BasicBlock();
void seal();
void dump(Executable const&) const;
ReadonlyBytes instruction_stream() const { return ReadonlyBytes { m_buffer, m_buffer_size }; }
size_t size() const { return m_buffer_size; }
void* next_slot() { return m_buffer + m_buffer_size; }
bool can_grow(size_t additional_size) const { return m_buffer_size + additional_size <= m_buffer_capacity; }
@ -65,7 +66,7 @@ public:
String const& name() const { return m_name; }
private:
BasicBlock(String name);
BasicBlock(String name, size_t size);
u8* m_buffer { nullptr };
size_t m_buffer_capacity { 0 };