beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-21 15:10:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

Meta: Disable readability-function-cognitive-complexity in clang-tidy

Browse source 
Feedback from contributors suggests that this warning doesn't help code
quality, and is seen as noisy.
This commit is contained in:
Andrew Kaster 2024-02-05 04:24:03 -07:00 committed by Andrew Kaster
parent 3078572f0d
commit e6762e8d4d
Notes: sideshowbarker 2024-07-17 06:33:00 +09:00 
Author: https://github.com/ADKaster
Commit: https://github.com/SerenityOS/serenity/commit/e6762e8d4d
Pull-request: https://github.com/SerenityOS/serenity/pull/23078
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
.clang-tidy
View file

@ -13,6 +13,7 @@
# performance-noexcept-move-constructor: The project does not use exceptions, so there are no such optimizations available
# performance-no-int-to-ptr: This rule flags every pointer to integer cast, which gets quite noisy. Should only be enabled on a case-by-case basis
# readability-braces-around-statements: Redundant braces around single-line conditions is against project style
# readability-function-cognitive-complexity: Most regular contributors seem to turn this one off anyway. Violations are hard to fix as well
# readability-magic-numbers: This check is very noisy in the codebase, especially in AK.
# readability-named-parameter: We frequently omit parameter names to work around -Wunused-parameter
# FIXME: readability-uppercase-literal-suffix: Enable this check, the rationale is solid but the findings are numerous
@ -38,6 +39,7 @@ Checks: >
-performance-noexcept-move-constructor,
-performance-no-int-to-ptr,
-readability-braces-around-statements,
-readability-function-cognitive-complexity,
-readability-identifier-length,
-readability-magic-numbers,
-readability-named-parameter,
@ -53,5 +55,3 @@ CheckOptions:
value: true
- key: readability-implicit-bool-conversion.AllowPointerConditions
value: true
- key: readability-function-cognitive-complexity.Threshold
value: 100 # FIXME: Lower this (30? 50?), and refactor complex functions