beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibJS: Parse line continuations in string literals properly

Browse source 
Newlines after line continuation were inserted into the string 
literals. This patch makes the parser ignore the newlines after \ and
also makes it so that "use strict" containing a line continuation is 
not a valid "use strict".
This commit is contained in:
Marcin Gasperowicz 2020-10-25 14:46:51 +01:00 committed by Andreas Kling
parent e6505a95f1
commit e5ddcadd3c
Notes: sideshowbarker 2024-07-19 01:44:24 +09:00 
Author: https://github.com/nooga
Commit: https://github.com/SerenityOS/serenity/commit/e5ddcadd3cc
Pull-request: https://github.com/SerenityOS/serenity/pull/3845
Issue: https://github.com/SerenityOS/serenity/issues/3816
Reviewed-by: https://github.com/linusg ✅
4 changed files with 18 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
Libraries/LibJS/Tests/functions/function-strict-mode.js
View file

@ -30,6 +30,12 @@ test("use strict with double quotes after statement does not yield strict mode c
expect(isStrictMode()).toBeFalse();
});
test("use strict interrupted by a line continuation does not yield strict mode code", () => {
"use \
strict";
expect(isStrictMode()).toBeFalse();
});
test("strict mode propagates down the scope chain", () => {
"use strict";
expect(isStrictMode()).toBeTrue();

7
Libraries/LibJS/Tests/template-literals.js
View file

@ -53,6 +53,13 @@ test("newline literals (not characters)", () => {
).toBe("foo\n bar");
});
test("line continuation in literals (not characters)", () => {
expect(
`foo\
bar`
).toBe("foo bar");
});
test("reference error from expressions", () => {
expect(() => `${b}`).toThrowWithMessage(ReferenceError, "'b' is not defined");
});

3
Libraries/LibJS/Tests/test-common-tests.js
View file

@ -53,6 +53,9 @@ test("toHaveLength", () => {
expect([1]).toHaveLength(1);
expect({ length: 1 }).toHaveLength(1);
expect("a\
b").toHaveLength(2);
expect(() => {
expect(1).toHaveLength();
}).toThrow(ExpectationError);

2
Libraries/LibJS/Token.cpp
View file

@ -155,6 +155,8 @@ String Token::string_value(StringValueStatus& status) const
case '\\':
builder.append('\\');
break;
case '\n':
break;
case 'x': {
if (i + 2 >= m_value.length() - offset)
return encoding_failure(StringValueStatus::MalformedHexEscape);