beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-22 07:30:19 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Properly append attributes to element when creating an Element

Browse source 
The main behavioural difference here is that the full qualified name is
appended to the element, rather than just the local name and value.
This commit is contained in:
Shannon Booth 2023-10-04 17:45:48 +13:00 committed by Sam Atkins
parent 8fbf72b5bf
commit e5d45eeeb1
Notes: sideshowbarker 2024-07-17 08:38:37 +09:00 
Author: https://github.com/shannonbooth
Commit: https://github.com/SerenityOS/serenity/commit/e5d45eeeb1
Pull-request: https://github.com/SerenityOS/serenity/pull/21227
Reviewed-by: https://github.com/AtkinsSJ ✅
Reviewed-by: https://github.com/kemzeb
3 changed files with 49 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

18
Tests/LibWeb/Text/expected/SVG/svg-href-qualified-name.txt Normal file
View file

@ -0,0 +1,18 @@
---------------
explicit-xlink-href
---------------
localName -> href
name -> xlink:href
namespaceURI -> http://www.w3.org/1999/xlink
ownerElement -> explicit-xlink-href
prefix -> xlink
value -> test
---------------
implicit-xlink-href
---------------
localName -> href
name -> href
namespaceURI -> null
ownerElement -> implicit-xlink-href
prefix -> null
value -> test

24
Tests/LibWeb/Text/input/SVG/svg-href-qualified-name.html Normal file
View file

@ -0,0 +1,24 @@
<script src="../include.js"></script>
<svg xmlns="http://www.w3.org/2000/svg">
<script id="explicit-xlink-href" xlink:href="test"></script>
<script id="implicit-xlink-href" href="test"></script>
</svg>
<script id="svg-script-element">
function dumpAttribute(elementName) {
println("---------------");
println(elementName);
println("---------------");
const attr = document.getElementById(elementName).attributes[1];
println(`localName -> ${attr.localName}`);
println(`name -> ${attr.name}`);
println(`namespaceURI -> ${attr.namespaceURI}`);
println(`ownerElement -> ${attr.ownerElement.id}`);
println(`prefix -> ${attr.prefix}`);
println(`value -> ${attr.value}`);
}
test(() => {
dumpAttribute('explicit-xlink-href');
dumpAttribute('implicit-xlink-href');
});
</script>

10
Userland/Libraries/LibWeb/HTML/Parser/HTMLParser.cpp
View file

@ -13,12 +13,14 @@
#include <LibWeb/Bindings/MainThreadVM.h>
#include <LibWeb/CSS/StyleValues/LengthStyleValue.h>
#include <LibWeb/CSS/StyleValues/PercentageStyleValue.h>
#include <LibWeb/DOM/Attr.h>
#include <LibWeb/DOM/Comment.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/DocumentType.h>
#include <LibWeb/DOM/ElementFactory.h>
#include <LibWeb/DOM/Event.h>
#include <LibWeb/DOM/ProcessingInstruction.h>
#include <LibWeb/DOM/QualifiedName.h>
#include <LibWeb/DOM/Text.h>
#include <LibWeb/HTML/CustomElements/CustomElementDefinition.h>
#include <LibWeb/HTML/EventLoop/EventLoop.h>
@ -649,6 +651,7 @@ HTMLParser::AdjustedInsertionLocation HTMLParser::find_appropriate_place_for_ins
return adjusted_insertion_location;
}
// https://html.spec.whatwg.org/multipage/parsing.html#create-an-element-for-the-token
JS::NonnullGCPtr<DOM::Element> HTMLParser::create_element_for(HTMLToken const& token, Optional<FlyString> const& namespace_, DOM::Node& intended_parent)
{
// FIXME: 1. If the active speculative HTML parser is not null, then return the result of creating a speculative mock element given given namespace, the tag name of the given token, and the attributes of the given token.
@ -692,9 +695,10 @@ JS::NonnullGCPtr<DOM::Element> HTMLParser::create_element_for(HTMLToken const& t
auto element = create_element(*document, local_name, namespace_, {}, is_value, will_execute_script).release_value_but_fixme_should_propagate_errors();
// 10. Append each attribute in the given token to element.
// FIXME: This isn't the exact `append` the spec is talking about.
token.for_each_attribute([&](auto& attribute) {
MUST(element->set_attribute(attribute.local_name, attribute.value));
token.for_each_attribute([&](auto const& attribute) {
DOM::QualifiedName qualified_name { attribute.local_name, attribute.prefix, attribute.namespace_ };
auto dom_attribute = realm().heap().allocate<DOM::Attr>(realm(), *document, move(qualified_name), attribute.value, element);
element->append_attribute(dom_attribute);
return IterationDecision::Continue;
});