LibJS: Remove ability to disable bytecode VM

This commit is contained in:
Andreas Kling 2023-08-07 16:52:31 +02:00
parent 9a709e03a3
commit e2c8d5859e
Notes: sideshowbarker 2024-07-16 23:55:09 +09:00
7 changed files with 2 additions and 24 deletions

View file

@ -14,7 +14,8 @@ TESTJS_PROGRAM_FLAG(test262_parser_tests, "Run test262 parser tests", "test262-p
TESTJS_GLOBAL_FUNCTION(is_bytecode_interpreter_enabled, isBytecodeInterpreterEnabled, 0) TESTJS_GLOBAL_FUNCTION(is_bytecode_interpreter_enabled, isBytecodeInterpreterEnabled, 0)
{ {
return JS::Value(JS::Bytecode::Interpreter::enabled()); // FIXME: Remove this function after updating the tests.
return JS::Value(true);
} }
TESTJS_GLOBAL_FUNCTION(is_strict_mode, isStrictMode, 0) TESTJS_GLOBAL_FUNCTION(is_strict_mode, isStrictMode, 0)

View file

@ -575,8 +575,6 @@ int main(int argc, char** argv)
args_parser.add_option(disable_core_dumping, "Disable core dumping", "disable-core-dump", 0); args_parser.add_option(disable_core_dumping, "Disable core dumping", "disable-core-dump", 0);
args_parser.parse(arguments); args_parser.parse(arguments);
JS::Bytecode::Interpreter::set_enabled(true);
#if !defined(AK_OS_MACOS) && !defined(AK_OS_EMSCRIPTEN) #if !defined(AK_OS_MACOS) && !defined(AK_OS_EMSCRIPTEN)
if (disable_core_dumping && prctl(PR_SET_DUMPABLE, 0, 0) < 0) { if (disable_core_dumping && prctl(PR_SET_DUMPABLE, 0, 0) < 0) {
perror("prctl(PR_SET_DUMPABLE)"); perror("prctl(PR_SET_DUMPABLE)");

View file

@ -19,18 +19,6 @@
namespace JS::Bytecode { namespace JS::Bytecode {
static bool s_bytecode_interpreter_enabled = false;
bool Interpreter::enabled()
{
return s_bytecode_interpreter_enabled;
}
void Interpreter::set_enabled(bool enabled)
{
s_bytecode_interpreter_enabled = enabled;
}
bool g_dump_bytecode = false; bool g_dump_bytecode = false;
Interpreter::Interpreter(VM& vm) Interpreter::Interpreter(VM& vm)

View file

@ -36,9 +36,6 @@ struct CallFrame {
class Interpreter { class Interpreter {
public: public:
[[nodiscard]] static bool enabled();
static void set_enabled(bool);
explicit Interpreter(VM&); explicit Interpreter(VM&);
~Interpreter(); ~Interpreter();

View file

@ -208,8 +208,6 @@ Bytecode::Interpreter& VM::bytecode_interpreter()
Bytecode::Interpreter* VM::bytecode_interpreter_if_exists() Bytecode::Interpreter* VM::bytecode_interpreter_if_exists()
{ {
if (!Bytecode::Interpreter::enabled())
return nullptr;
return m_bytecode_interpreter; return m_bytecode_interpreter;
} }

View file

@ -134,8 +134,6 @@ int main(int argc, char** argv)
AK::set_debug_enabled(false); AK::set_debug_enabled(false);
} }
JS::Bytecode::Interpreter::set_enabled(true);
DeprecatedString test_root; DeprecatedString test_root;
if (!specified_test_root.is_empty()) { if (!specified_test_root.is_empty()) {

View file

@ -576,8 +576,6 @@ ErrorOr<int> serenity_main(Main::Arguments arguments)
args_parser.add_positional_argument(script_paths, "Path to script files", "scripts", Core::ArgsParser::Required::No); args_parser.add_positional_argument(script_paths, "Path to script files", "scripts", Core::ArgsParser::Required::No);
args_parser.parse(arguments); args_parser.parse(arguments);
JS::Bytecode::Interpreter::set_enabled(true);
bool syntax_highlight = !disable_syntax_highlight; bool syntax_highlight = !disable_syntax_highlight;
AK::set_debug_enabled(!disable_debug_printing); AK::set_debug_enabled(!disable_debug_printing);