beenull/ladybird
1
0
Fork 0
mirror of https://github.com/LadybirdBrowser/ladybird.git synced 2024-11-26 01:20:25 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 6

LibWeb: Close acquired writer in AO readable_stream_pipe_to()

Browse source 
Also adds a test to prove that the WritableStream's close callback is
called.
This commit is contained in:
Kenneth Myhra 2024-05-20 10:42:33 +02:00 committed by Tim Flynn
parent 15b677385c
commit e2c4019bfc
Notes: sideshowbarker 2024-07-16 23:55:09 +09:00 
Author: https://github.com/kennethmyhra
Commit: https://github.com/SerenityOS/serenity/commit/e2c4019bfc
Pull-request: https://github.com/SerenityOS/serenity/pull/24132
Reviewed-by: https://github.com/shannonbooth
Reviewed-by: https://github.com/trflynn89
3 changed files with 29 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
Tests/LibWeb/Text/expected/Streams/ReadableStream-pipeTo-Writer-close-callback-called.txt Normal file
View file

@ -0,0 +1 @@
Writer has been closed.

20
Tests/LibWeb/Text/input/Streams/ReadableStream-pipeTo-Writer-close-callback-called.html Normal file
View file

@ -0,0 +1,20 @@
<script src="../include.js"></script>
<script>
asyncTest(done => {
const writableStream = new WritableStream({
close() {
println("Writer has been closed.");
}
}
);
const stream = new ReadableStream({
pull(controller) {
controller.close();
}
});
stream.pipeTo(writableStream).then(() => {
done();
});
});
</script>

10
Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp
View file

@ -314,11 +314,17 @@ JS::NonnullGCPtr<WebIDL::Promise> readable_stream_pipe_to(ReadableStream& source
WebIDL::resolve_promise(realm, promise, JS::js_undefined());
};
auto success_steps = [promise, &realm](ByteBuffer) {
auto success_steps = [promise, &realm, writer](ByteBuffer) {
// Make sure we close the acquired writer.
WebIDL::resolve_promise(realm, writable_stream_default_writer_close(*writer), JS::js_undefined());
WebIDL::resolve_promise(realm, promise, JS::js_undefined());
};
auto failure_steps = [promise, &realm](JS::Value error) {
auto failure_steps = [promise, &realm, writer](JS::Value error) {
// Make sure we close the acquired writer.
WebIDL::resolve_promise(realm, writable_stream_default_writer_close(*writer), JS::js_undefined());
WebIDL::reject_promise(realm, promise, error);
};